Skip to content
Snippets Groups Projects

Update ohai gem to 18.1.3

Merged Andrew Patterson requested to merge update-ohai-v18 into master

What does this MR do and why?

Update the ohai gem to 3.1.3 to support ruby 3.1.

Related

Closes #424131 (closed)

How to set up and validate locally

  1. Green pipeline.

  2. Install omnibus package.

  3. Verify ohai version is installed:

    /opt/gitlab/embedded/bin/gem list ohai
    *** LOCAL GEMS ***
    
    ohai (18.1.3, 17.9.0)
  4. Check version in rails:

    sudo gitlab-rails console
    irb(main):001:0> Gem.loaded_specs["ohai"]
    .
    .
    .
    s.name = "ohai"
    s.version = Gem::Version.new("18.1.3")
    .
    .
    .
  5. Verify operating system returned by ohai:

    sudo gitlab-rake gitlab:usage_data:generate | grep operating_system
    "operating_system": "ubuntu-22.04",

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Andrew Patterson

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Contributor
    1 Warning
    :warning: This Merge Request needs to be labelled with backend. Please request a reviewer or maintainer to add them.
    1 Message
    :book: CHANGELOG missing:

    If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend @hraghuvanshi profile link current availability (UTC+5.5, 11.5 hours ahead of author) @vyaklushin profile link current availability (UTC+1, 7 hours ahead of author)

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    Rubygems

    This merge request adds, or changes a Rubygems dependency. Please review the Gemfile guidelines.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

    Edited by Ghost User
  • Andrew Patterson added 31 commits

    added 31 commits

    Compare with previous version

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :exclamation: test report for 736e4f24

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Verify           | 32     | 0      | 0       | 1     | 32    | ❗     |
    | Govern           | 48     | 0      | 0       | 0     | 48    | ✅     |
    | Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
    | Create           | 40     | 0      | 6       | 0     | 46    | ✅     |
    | Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 201    | 0      | 9       | 1     | 210   | ❗     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for 736e4f24

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 539    | 0      | 101     | 0     | 640   | ✅     |
    | Verify           | 155    | 1      | 9       | 0     | 165   | ❌     |
    | Plan             | 249    | 0      | 10      | 0     | 259   | ✅     |
    | Manage           | 40     | 0      | 10      | 1     | 50    | ❗     |
    | Govern           | 303    | 0      | 12      | 3     | 315   | ❗     |
    | Fulfillment      | 8      | 0      | 69      | 0     | 77    | ✅     |
    | Data Stores      | 117    | 0      | 3       | 0     | 120   | ✅     |
    | Systems          | 8      | 0      | 0       | 0     | 8     | ✅     |
    | GitLab Metrics   | 2      | 0      | 1       | 1     | 3     | ❗     |
    | Package          | 226    | 0      | 17      | 3     | 243   | ❗     |
    | Analytics        | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Release          | 15     | 0      | 3       | 0     | 18    | ✅     |
    | Secure           | 6      | 0      | 3       | 0     | 9     | ✅     |
    | ModelOps         | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Configure        | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Monitor          | 39     | 0      | 7       | 0     | 46    | ✅     |
    | Growth           | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Framework sanity | 0      | 0      | 5       | 0     | 5     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 1715   | 1      | 271     | 8     | 1987  | ❌     |
    +------------------+--------+--------+---------+-------+-------+--------+
    Edited by Ghost User
  • Andrew Patterson marked this merge request as ready

    marked this merge request as ready

  • Andrew Patterson marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Andrew Patterson changed title from Update ohai gem to 3.1.3 to Update ohai gem to 18.1.3

    changed title from Update ohai gem to 3.1.3 to Update ohai gem to 18.1.3

  • Andrew Patterson requested review from @sdungarwal

    requested review from @sdungarwal

  • Siddharth Dungarwal approved this merge request

    approved this merge request

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading