Change 'children spans' to 'child spans'

What does this MR do?

Updates the string expand children spans to expand child spans. It's a change to an ARIA label, and so invisible to users who do not rely on ARIA navigation.

In this thread we discussed various possibilities, and were nearly settled on Expand child spans. When I looked at ee/app/assets/javascripts/tracing/components/tracing_details_spans_chart.vue I realized this string probably handled both the open and closed states of the parent span, which meant expand would be wrong 50% of the time.

Toggle, then.

Related issues

Related to Review text/messages with technical writer (gitlab-org/opstrace/opstrace#2474 - closed)

Author's checklist

• Optional. Consider taking the GitLab Technical Writing Fundamentals course.
• Follow the:
  • Documentation process.
  • Documentation guidelines.
  • Style Guide.
• If you're adding or changing the main heading of the page (H1), ensure that the product tier badge is added.
• If you are a GitLab team member, request a review based on:
  • The documentation page's metadata.
  • The associated Technical Writer.

If you are a GitLab team member and only adding documentation, do not add any of the following labels:

• ~"frontend"
• ~"backend"
• ~"type::bug"
• ~"database"

These labels cause the MR to be added to code verification QA issues.

Reviewer's checklist

Documentation-related MRs should be reviewed by a Technical Writer for a non-blocking review, based on Documentation Guidelines and the Style Guide.

If you aren't sure which tech writer to ask, use roulette or ask in the #docs Slack channel.

• If the content requires it, ensure the information is reviewed by a subject matter expert.
• Technical writer review items:
  • Ensure docs metadata is present and up-to-date.
  • Ensure the appropriate labels are added to this MR.
  • Ensure a release milestone is set.
  • If relevant to this MR, ensure content topic type principles are in use, including:
    • The headings should be something you'd do a Google search for. Instead of Default behavior, say something like Default behavior when you close an issue.
    • The headings (other than the page title) should be active. Instead of Configuring GDK, say something like Configure GDK.
    • Any task steps should be written as a numbered list.
    • If the content still needs to be edited for topic types, you can create a follow-up issue with the docs-technical-debt label.
• Review by assigned maintainer, who can always request/require the reviews above. Maintainer's review can occur before or after a technical writer review.

added Technical Writing UI text devopsanalyze docsimprovement documentation groupobservability maintenancerefactor tw-weight3 twdoing typemaintenance labels

assigned to @aqualls

added sectionanalytics label

changed the description

requested review from @drosse

changed milestone to %16.6

mentioned in issue gitlab-org/opstrace/opstrace#2474 (closed)

added frontend label

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: ❗ test report for 2248930e

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Govern           | 48     | 0      | 0       | 0     | 48    | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Create           | 40     | 0      | 6       | 0     | 46    | ✅     |
| Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
| Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
| Verify           | 32     | 0      | 0       | 1     | 32    | ❗     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 201    | 0      | 9       | 1     | 210   | ❗     |
+------------------+--------+--------+---------+-------+-------+--------+

e2e-review-qa: ✅ test report for 2248930e

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Govern           | 3      | 0      | 0       | 0     | 3     | ✅     |
| Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
| Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
| Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 20     | 0      | 4       | 0     | 24    | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

approved this merge request

added pipeline:mr-approved label

Neat!

Sending over to @apennells for review. (I see you're a FE maintainer trainee - here's an easy one!)

requested review from @apennells

approved this merge request

requested review from @jivanvl and removed review request for @apennells

resolved all threads

approved this merge request

enabled an automatic merge when the pipeline for 8c09491f succeeds

Bundle size analysis [beta]

This compares changes in bundle size for entry points between the commits 2c3dc388 and 2248930e

✨ Special assets

Entrypoint / Name	Size before	Size after	Diff	Diff in percent
average	4.11 MB	4.11 MB	-	0.0 %
mainChunk	3.06 MB	3.06 MB	-	0.0 %

---

Note: We do not have exact data for 2c3dc388. So we have used data from: 84e8d539.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun the bundle-size-review job
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

Please look at the full report for more details

---

Read more about how this report works.

Generated by 🚫 Danger