Cleanup for converted ci_pipelines.auto_canceled_by_id
What does this MR do and why?
Cleanup for converted ci_pipelines.auto_canceled_by_id
This is to step to remove the trigger and old integer column See https://docs.gitlab.com/ee/development/database/avoiding_downtime_in_migrations.html#remove-the-trigger-and-old-integer-columns-release-n--2
- Backfill is done at !126645 (merged)
- Index is created at !129201 (merged) and !131108 (merged)
- Foreign key is created at !132609 (merged) and !133162 (merged)
- Columns swap is done at !134597 (merged)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #422811 (closed)
Merge request reports
Activity
changed milestone to %16.7
assigned to @tianwenchen
Allure report
allure-report-publishergenerated test report!e2e-test-on-gdk:
✅ test report for d1f234c8expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 40 | 0 | 7 | 0 | 47 | ✅ | | Govern | 57 | 0 | 0 | 0 | 57 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | | Verify | 32 | 0 | 0 | 0 | 32 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 210 | 0 | 10 | 0 | 220 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+Edited by Ghost Useradded 2269 commits
-
d34cab2e...a3acbe14 - 2268 commits from branch
master - caa14554 - Remove ignore rule for ci_pipelines.auto_canceled_by_id conversion
-
d34cab2e...a3acbe14 - 2268 commits from branch
- A deleted user
added backend databasereview pending labels
1 Warning ⚠ You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer database @jarka
(UTC+1, 10 hours behind author)
@ghavenga (UTC+2, 9 hours behind author)
Please check reviewer's status!
-
Reviewer is available!
-
Reviewer is unavailable!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-reviewjob that generated this comment.Generated by
🚫 DangerEdited by Ghost User-
added 1 commit
- 64d370b4 - Cleanup for converted ci_pipelines.auto_canceled_by_id conversion
- A deleted user
added Data WarehouseImpact Check label
added 469 commits
-
64d370b4...8e079cd2 - 468 commits from branch
master - d1f234c8 - Cleanup for converted ci_pipelines.auto_canceled_by_id conversion
-
64d370b4...8e079cd2 - 468 commits from branch
Database migrations (on the main database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20231114053330 - CleanupCiPipelinesAutoCanceledByIdBigint Post deploy 4.3 s ✅ -8.00 KiB Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 5 0.1 seconds - 1 second 1 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20231114053330 - CleanupCiPipelinesAutoCanceledByIdBigint
- Type: Post deploy
- Duration: 4.3 s
- Database size change: -8.00 KiB
Calls Total Time Max Time Mean Time Rows Query 1 74.1 ms 74.1 ms 74.1 ms 0 ALTER TABLE "ci_pipelines" DROP COLUMN "auto_canceled_by_id_convert_to_bigint"
1 22.5 ms 22.5 ms 22.5 ms 0 DROP TRIGGER IF EXISTS trigger_1bd97da9c1a4 ON "ci_pipelines"
1 12.1 ms 12.1 ms 12.1 ms 0 DROP FUNCTION IF EXISTS trigger_1bd97da9c1a4()
1 0.1 ms 0.1 ms 0.1 ms 1 SELECT "feature_gates"."key", "feature_gates"."value" FROM "feature_gates" WHERE "feature_gates"."feature_key" = $1
2 0.0 ms 0.0 ms 0.0 ms 2 SELECT pg_backend_pid()
Histogram for CleanupCiPipelinesAutoCanceledByIdBigint
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 5 0.1 seconds - 1 second 1 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Other information
No other migrations pending on GitLab.com
Clone details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-2543767-11951963-main2023-11-20T05:07:43Z 2023-11-20T04:11:27Z 2023-11-20 17:11:38 +0000 database-testing-2543767-11951963-ci2023-11-20T05:07:43Z 2023-11-20T04:45:42Z 2023-11-20 17:11:38 +0000 Database migrations (on the ci database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20231114053330 - CleanupCiPipelinesAutoCanceledByIdBigint Post deploy 3.3 s ✅ -6.68 GiB Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 5 0.1 seconds - 1 second 0 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20231114053330 - CleanupCiPipelinesAutoCanceledByIdBigint
- Type: Post deploy
- Duration: 3.3 s
- Database size change: -6.68 GiB
Calls Total Time Max Time Mean Time Rows Query 1 22.7 ms 22.7 ms 22.7 ms 0 ALTER TABLE "ci_pipelines" DROP COLUMN "auto_canceled_by_id_convert_to_bigint"
1 16.2 ms 16.2 ms 16.2 ms 0 DROP TRIGGER IF EXISTS trigger_1bd97da9c1a4 ON "ci_pipelines"
1 7.7 ms 7.7 ms 7.7 ms 0 DROP FUNCTION IF EXISTS trigger_1bd97da9c1a4()
2 0.0 ms 0.0 ms 0.0 ms 2 SELECT pg_backend_pid()
Histogram for CleanupCiPipelinesAutoCanceledByIdBigint
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 5 0.1 seconds - 1 second 0 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Other information
No other migrations pending on GitLab.com
Clone details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-2543767-11951963-main2023-11-20T05:07:43Z 2023-11-20T04:11:27Z 2023-11-20 17:11:38 +0000 database-testing-2543767-11951963-ci2023-11-20T05:07:43Z 2023-11-20T04:45:42Z 2023-11-20 17:11:38 +0000
Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic
Edited by Ghost User- A deleted user
added database-testing-automation label
requested review from @mwoolf
- Resolved by Marius Bobin
@mwoolf could you help to do the review? If it looks good to you, could you help to pass it onto
@mbobin? Thanks in advance! - Last reply by Max Woolf
added databasereviewed label and removed databasereview pending label
