Extract members_with_parents into another class
What does this MR do and why?
NOTE: It will be easier to review commit-by-commit
Related issue: #422405 (closed), #417455 (closed), https://gitlab.com/gitlab-org/gitlab/-/issues/421527
Extract members_with_parents
into another class
Reduces the size of the Group class. We move code that is not strictly related to a group to its own class - this code is more to do with the hierarchy of groups' members.
Why? See https://docs.gitlab.com/ee/development/software_design.html#taming-omniscient-classes
Also it will make Cells: Fix cross-joins arising from members (#422405 - closed) easier to fix
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.