Cells: Fix cross-joins arising from members
All cross-joins that are currently allowed to pass that arises from members
should be fixed. They are marked in the codebase with allow_cross_joins_across_databases(url: "https://gitlab.com/gitlab-org/gitlab/-/issues/422405")
-
app/models/group.rb:42: .allow_cross_joins_across_databases(url: "#422405 (closed)") -
app/models/project.rb:347: has_many :users, -> { allow_cross_joins_across_databases(url: "#422405 (closed)") }, -
app/models/project.rb:351: allow_cross_joins_across_databases(url: "#422405 (closed)") -
app/models/project_team.rb:81: .allow_cross_joins_across_databases(url: '#422405 (closed)') -
app/services/groups/destroy_service.rb:99: .allow_cross_joins_across_databases(url: '#422405 (closed)') -
app/services/projects/destroy_service.rb:259: .allow_cross_joins_across_databases(url: '#422405 (closed)') -
app/services/jira_import/users_mapper_service.rb .allow_cross_joins_across_databases(url: "#422405 (closed)") -
doc/development/database/multiple_databases.md:524: allow_cross_joins_across_databases(url: "#422405 (closed)") -
doc/development/database/multiple_databases.md:538: super.allow_cross_joins_across_databases(url: "#422405 (closed)") -
ee/app/finders/ee/group_members_finder.rb:22: .allow_cross_joins_across_databases(url: '#422405 (closed)') -
ee/app/models/ee/group_member.rb:18: .allow_cross_joins_across_databases(url: '#422405 (closed)') -
ee/app/models/ee/group_member.rb:27: .allow_cross_joins_across_databases(url: '#422405 (closed)') -
ee/app/models/ee/project.rb:158: security_policy_bot.allow_cross_joins_across_databases(url: "#422405 (closed)") -
ee/app/models/ee/user.rb:132: .allow_cross_joins_across_databases(url: '#422405 (closed)') -
ee/app/models/ee/user.rb:138: .allow_cross_joins_across_databases(url: '#422405 (closed)') -
ee/app/services/ldap_group_reset_service.rb:18: '#422405 (closed)') do -
ee/app/workers/elastic/namespace_update_worker.rb:42: "#422405 (closed)") do -
ee/lib/ee/gitlab/auth/ldap/sync/group.rb:315: .allow_cross_joins_across_databases(url: "#422405 (closed)") -
ee/spec/services/security/security_orchestration_policies/validate_policy_service_spec.rb:242: "#422405 (closed)") do -
spec/models/concerns/expirable_spec.rb:21: '#422405 (closed)') do
Refer to the epic for more information about this. Feel free to:
- Copy the epic description to this issue to helper the reviewers understand the problem.
- Split this issue into different issues in case it was so much effort to
- Ask for help and hints on #g_tenant-scale on how to fix cross joins
Be aware of #428105
Edited by Manoj M J