Skip to content

Remove usages of .font-size-inherit

Miguel Rincon requested to merge 429351-remove-font-inherit into master

What does this MR do and why?

Due to an font override in the gitlab-ui links that were rendered in containers with small text needed to reset the font size to have the style of their container.

This change also removes such overrides and also replaces the css class .font-size-inherit in favor of gitlab-ui .gl-reset-font-size

Screenshots or screen recordings

URL View
http://gdk.test:3000/flightjs/Flight/-/blob/master/index.js Screenshot_2023-10-25_at_15.17.05
http://gdk.test:3000/flightjs/Flight/edit (enable service desk) image
http://gdk.test:3000/flightjs/Flight/-/releases/v1.5.2 (create a release) image
http://gdk.test:3000/top-group/top-project/-/merge_requests/3 Screenshot_2023-10-25_at_15.35.39
http://gdk.test:3000/top-group/top-project/-/dependencies Screenshot_2023-10-25_at_15.38.14

How to set up and validate locally

Visit URLs above.

I made a code change for blob to show the modal in the first row
diff --git a/app/assets/javascripts/pages/projects/blob/show/index.js b/app/assets/javascripts/pages/projects/blob/show/index.js
index d42fb10063ef..1aad7260ced0 100644
--- a/app/assets/javascripts/pages/projects/blob/show/index.js
+++ b/app/assets/javascripts/pages/projects/blob/show/index.js
@@ -193,7 +193,7 @@ if (codeNavEl && !viewBlobEl) {
 
 const successPipelineEl = document.querySelector('.js-success-pipeline-modal');
 
-if (successPipelineEl) {
+if (true || successPipelineEl) {
   // eslint-disable-next-line no-new
   new Vue({
     el: successPipelineEl,

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #429351 (closed)

Edited by Miguel Rincon

Merge request reports