Skip to content
Snippets Groups Projects

Remove usages of .font-size-inherit

Merged Miguel Rincon requested to merge 429351-remove-font-inherit into master

What does this MR do and why?

Due to an font override in the gitlab-ui links that were rendered in containers with small text needed to reset the font size to have the style of their container.

This change also removes such overrides and also replaces the css class .font-size-inherit in favor of gitlab-ui .gl-reset-font-size

Screenshots or screen recordings

URL View
http://gdk.test:3000/flightjs/Flight/-/blob/master/index.js Screenshot_2023-10-25_at_15.17.05
http://gdk.test:3000/flightjs/Flight/edit (enable service desk) image
http://gdk.test:3000/flightjs/Flight/-/releases/v1.5.2 (create a release) image
http://gdk.test:3000/top-group/top-project/-/merge_requests/3 Screenshot_2023-10-25_at_15.35.39
http://gdk.test:3000/top-group/top-project/-/dependencies Screenshot_2023-10-25_at_15.38.14

How to set up and validate locally

Visit URLs above.

I made a code change for blob to show the modal in the first row
diff --git a/app/assets/javascripts/pages/projects/blob/show/index.js b/app/assets/javascripts/pages/projects/blob/show/index.js
index d42fb10063ef..1aad7260ced0 100644
--- a/app/assets/javascripts/pages/projects/blob/show/index.js
+++ b/app/assets/javascripts/pages/projects/blob/show/index.js
@@ -193,7 +193,7 @@ if (codeNavEl && !viewBlobEl) {
 
 const successPipelineEl = document.querySelector('.js-success-pipeline-modal');
 
-if (successPipelineEl) {
+if (true || successPipelineEl) {
   // eslint-disable-next-line no-new
   new Vue({
     el: successPipelineEl,

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #429351 (closed)

Edited by Miguel Rincon

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • assigned to @mrincon

    • Contributor
      Resolved by Payton Burdette
      5 Warnings
      There were no new or modified feature flag YAML files detected in this MR.

      If the changes here are already controlled under an existing feature flag, please add
      the feature flagexists. Otherwise, if you think the changes here don't need
      to be under a feature flag, please add the label feature flagskipped, and
      add a short comment about why we skipped the feature flag.

      For guidance on when to use a feature flag, please see the documentation.

      This merge request contains deprecated components. Please consider using Pajamas components instead.
      This merge request contains lines with testid selectors. Please ensure e2e:package-and-test job is run.
      This merge request adds a new rule to app/assets/stylesheets/framework/common.scss or app/assets/stylesheets/utilities.scss.

      This merge request changed undocumented Vue components in vue_shared/. Please consider creating Stories for these components:

      • ee/app/assets/javascripts/vue_shared/components/code_owners/code_owners.vue

      Deprecated components

      These deprecated components are in the process of being migrated. Please consider using Pajamas components instead.

      • .tooltip

      Testid Selectors

      The following changed lines in this MR contain testid selectors:

      • file app/assets/javascripts/vue_merge_request_widget/components/mr_widget_suggest_pipeline.vue:
        •              data-testid="help"
        •            <gl-link data-testid="help" :href="$options.SP_HELP_URL" target="_blank"

      If the e2e:package-and-test job in the qa stage has run automatically, please ensure the tests are passing. If the job has not run, please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and ensure the tests in follow-up-e2e:package-and-test-ee pipeline are passing.

      For the list of known failures please refer to the latest pipeline triage issue.

      If your changes are under a feature flag, please check our Testing with feature flags documentation for instructions.

      Reviewer roulette

      Changes that require review have been detected!

      Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

      Category Reviewer Maintainer
      frontend @bsandlin profile link current availability (UTC-5, 7 hours behind author) @cngo profile link current availability (UTC+1, 1 hour behind author)

      Please check reviewer's status!

      • available Reviewer is available!
      • unavailable Reviewer is unavailable!

      Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

      To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

      Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

      Changes to utility SCSS files

      Addition to app/assets/stylesheets/utilities.scss

      You have added a new rule to app/assets/stylesheets/utilities.scss. Are you sure you need this rule?

      If it is a component class shared across items, could it be added to the component as a utility class or to the component's stylesheet? If not, consider adding it to app/assets/stylesheets/framework/common.scss

      If it is a new utility class, is there another class that shares the same values in either this file or in app/assets/stylesheets/utilities.scss? If not, please be sure this addition follows the Gitlab UI naming style so it may be removed when these rules are included. See Include gitlab-ui utility-class library for more about this project.

      If needed, you can retry the 🔁 danger-review job that generated this comment.

      Generated by 🚫 Danger

      Edited by Ghost User
  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: test report for 73f81d5c

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 51     | 0      | 0       | 0     | 51    | ✅     |
    | Create      | 32     | 0      | 5       | 0     | 37    | ✅     |
    | Data Stores | 20     | 0      | 0       | 0     | 20    | ✅     |
    | Govern      | 43     | 0      | 2       | 0     | 45    | ✅     |
    | Verify      | 20     | 0      | 0       | 0     | 20    | ✅     |
    | Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 166    | 0      | 8       | 0     | 174   | ✅     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-review-qa: test report for 73f81d5c

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Verify           | 20     | 0      | 0       | 0     | 20    | ✅     |
    | Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Govern           | 3      | 0      | 0       | 0     | 3     | ✅     |
    | Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 40     | 0      | 4       | 0     | 44    | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    Edited by Ghost User
  • Miguel Rincon changed milestone to %16.6

    changed milestone to %16.6

  • Setting label grouprunner based on @mrincon's group.

  • Miguel Rincon deleted the 2357-remove-font-inherit-in-gl-link-usages-in-the-project branch. This merge request now targets the master branch

    deleted the 2357-remove-font-inherit-in-gl-link-usages-in-the-project branch. This merge request now targets the master branch

  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits a9160c3f and 73f81d5c

    Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.11 MB 4.11 MB - -0.0 %
    mainChunk 3.06 MB 3.06 MB - 0.0 %

    Note: We do not have exact data for a9160c3f. So we have used data from: fa884b1c.
    The target commit was too new, so we used the latest commit from master we have info on.
    It might help to rerun the bundle-size-review job
    This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by 🚫 Danger

    Edited by Ghost User
  • Miguel Rincon added 380 commits

    added 380 commits

    Compare with previous version

  • Miguel Rincon changed the description

    changed the description

  • Miguel Rincon requested review from @bsandlin

    requested review from @bsandlin

  • Briley Sandlin approved this merge request

    approved this merge request

  • Briley Sandlin requested review from @pburdette and removed review request for @bsandlin

    requested review from @pburdette and removed review request for @bsandlin

  • Contributor

    @mrincon Some end-to-end (E2E) tests should run based on the stage label.

    Please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and ensure tests in the follow-up-e2e:package-and-test-ee pipeline pass before this MR is merged. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)

    To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.

    E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.

    Once done, apply the emoji on this comment.

    Team members only: for any questions or help, reach out on the internal #quality Slack channel.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply
Loading