Remove unused methods in ViteHelper module

changed milestone to %16.6

added backend groupcode review maintenanceremoval labels

@slashmanov here's the MR removing the code we discussed in Slack. I'm leaving this as Draft until specs run clean and I get an official from you that this is in fact ok to remove!

requested review from @slashmanov

	1 Warning
	You've made some app changes, but didn't add any tests. That's OK as long as you're refactoring existing code, but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.

1 Message

CHANGELOG missing:

If this merge request needs a changelog entry, add the Changelog trailer to the commit message you want to add to the changelog.

If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	`@alexbuijs` (UTC+2, 9 hours ahead of author)	`@stanhu` (UTC-7, same timezone as author)

Please check reviewer's status!

Reviewer is available!
Reviewer is unavailable!

Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

added 1 commit

579550dd - Remove unused helper methods

Compare with previous version

changed title from Draft: Remove unused ViteHelper module to Draft: Remove unused methods in ViteHelper module

changed the description

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 579550dd

expand test summary

+------------------------------------------------------------------+
|                          suites summary                          |
+-------------+--------+--------+---------+-------+-------+--------+
|             | passed | failed | skipped | flaky | total | result |
+-------------+--------+--------+---------+-------+-------+--------+
| Govern      | 42     | 0      | 3       | 0     | 45    | ✅     |
| Create      | 40     | 0      | 6       | 0     | 46    | ✅     |
| Verify      | 20     | 0      | 0       | 0     | 20    | ✅     |
| Data Stores | 20     | 0      | 0       | 0     | 20    | ✅     |
| Plan        | 51     | 0      | 0       | 0     | 51    | ✅     |
| Manage      | 0      | 0      | 1       | 0     | 1     | ➖     |
+-------------+--------+--------+---------+-------+-------+--------+
| Total       | 173    | 0      | 10      | 0     | 183   | ✅     |
+-------------+--------+--------+---------+-------+-------+--------+

e2e-package-and-test: test report for 579550dd

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 539    | 0      | 102     | 0     | 641   | ✅     |
| Monitor          | 8      | 0      | 0       | 0     | 8     | ✅     |
| Framework sanity | 0      | 0      | 2       | 0     | 2     | ➖     |
| Package          | 0      | 0      | 2       | 0     | 2     | ➖     |
| Govern           | 6      | 0      | 0       | 0     | 6     | ✅     |
| Plan             | 8      | 0      | 0       | 0     | 8     | ✅     |
| Data Stores      | 4      | 0      | 0       | 0     | 4     | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 565    | 0      | 106     | 0     | 671   | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

marked this merge request as ready

marked this merge request as draft

approved this merge request

@slashmanov, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

added pipeline:mr-approved label

removed review request for @slashmanov

resolved all threads

@robyrne could you start the review process off here?

requested review from @robyrne

marked this merge request as ready

approved this merge request

requested review from @stanhu and removed review request for @robyrne

approved this merge request

resolved all threads

merged

@stanhu, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:

Ensure the merge request is not in Draft status.
Start a pipeline (especially important for Community contribution merge requests).
Set the merge request to auto-merge.

This is a guideline, not a rule. Please consider replying to this comment for transparency.

This message was generated automatically. You're welcome to improve it.