Skip to content
Snippets Groups Projects

Add Vite for javascript assets

Merged Stanislav Lashmanov requested to merge slashmanov/vite-js-dev-2 into master
All threads resolved!

What does this MR do and why?

RFC

This MR adds vite as a frontend runner for javascript assets instead of webpack in development mode.

This is intended only for developer experience evaluation purposes. That's why it's behind a feature flag.

This MR fixes the issue with the CNG deployments from Add Vite for javascript assets in development mode (!115469 - merged).

How to test locally

  1. Run echo "Feature.enable(:vite)" | gdk rails c
  2. Launch bundle exec vite dev
  3. Restart GDK

Issues with local vite server

Current configuration assumes you've set up gdk.test domain on a specific IP address. In case you're running it on localhost please change config/vite.json development host to localhost.

How to build

Make sure you have 10GB of RAM free. :smile:

  1. Run NODE_OPTIONS="--max_old_space_size=10240" bundle exec vite build
Edited by Stanislav Lashmanov

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Mark Florian
  • Mark Florian approved this merge request

    approved this merge request

  • Mark Florian removed review request for @markrian

    removed review request for @markrian

  • :wave: @markrian, thanks for approving this merge request.

    This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Stanislav Lashmanov added 1417 commits

    added 1417 commits

    Compare with previous version

  • Stanislav Lashmanov requested review from @jennli

    requested review from @jennli

  • Stanislav Lashmanov added 416 commits

    added 416 commits

    Compare with previous version

  • Jennifer Li approved this merge request

    approved this merge request

  • Jennifer Li resolved all threads

    resolved all threads

  • Jennifer Li enabled an automatic merge when the pipeline for b0aaa95e succeeds

    enabled an automatic merge when the pipeline for b0aaa95e succeeds

  • merged

  • Jennifer Li mentioned in commit aa04f862

    mentioned in commit aa04f862

  • added workflowstaging label and removed workflowcanary label

  • Kerri Miller mentioned in commit 0b9cdf25

    mentioned in commit 0b9cdf25

  • Kerri Miller mentioned in merge request !135022 (merged)

    mentioned in merge request !135022 (merged)

  • Kerri Miller mentioned in commit 579550dd

    mentioned in commit 579550dd

  • :wave: Is there an issue or epic where I can follow progress? I just wanted to highlight that GCK uses webpack, so we may need to prepare it to support this new tool as well.

  • Please register or sign in to reply
    Loading