Introduce remediations to activity filter
What does this MR do and why?
Add "Solution" (Remediation) section to the Activity filter
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
 |
 |
How to set up and validate locally
- Have the related FF enabled:
echo "Feature.enable(:activity_filter_has_remediations)" | rails c - In order to run a pipeline to generate a Vulnerability report, you'll need an EE license.
- Fork https://gitlab.com/gitlab-org/govern/demos/sandbox/minac/test-remediations.
- Run a pipeline against the default branch. It will generate vulnerabilities.
- Go to the project vulnerability report page
- Select an "Activity" filter, it will have the "Solution available" items
- When selected, the vulnerabilities will be filtered accordingly
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #427622 (closed)
Merge request reports
Activity
changed milestone to %Backlog
assigned to @sming-gitlab
2 Warnings ⚠ featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
⚠ This Merge Request needs to be labelled with feature flag, backend. Please request a reviewer or maintainer to add them. 1 Message 📖 CHANGELOG missing: If this merge request needs a changelog entry, add the
Changelogtrailer to the commit message you want to add to the changelog.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @partiaga
(UTC+11, 10 hours ahead of author)@ahmed.hemdan (UTC+1, same timezone as author)frontend @minahilnichols (UTC-4, 5 hours behind author)@himkp (UTC+1, same timezone as author)Please check reviewer's status!
-
Reviewer is available!
-
Reviewer is unavailable!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
🔁 danger-reviewjob that generated this comment.Generated by
🚫 DangerEdited by Ghost Usermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@e44c91c6
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 5cd75933 and 7e1127ff
✨ Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.11 MB 4.11 MB - 0.0 % mainChunk 3.06 MB 3.06 MB - 0.0 %
Note: We do not have exact data for 5cd75933. So we have used data from: 2d79ea34.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
🚫 DangerEdited by Ghost Useradded pipeline:run-all-e2e label
Resolved by Savas Vedova@bala.kumar @subashis - fyi, this is the implementation for the
hasRemedationsfilter😀 - Last reply by Samantha Ming
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@62070459
Allure report
allure-report-publishergenerated test report!e2e-test-on-gdk:
❗ test report for 7e1127ffexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Create | 40 | 0 | 6 | 0 | 46 | ✅ | | Verify | 32 | 0 | 0 | 1 | 32 | ❗ | | Govern | 48 | 0 | 0 | 0 | 48 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 201 | 0 | 9 | 1 | 210 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+e2e-package-and-test:
❗ test report for 7e1127ffexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 668 | 0 | 127 | 0 | 795 | ✅ | | Manage | 43 | 0 | 12 | 1 | 55 | ❗ | | Package | 260 | 0 | 21 | 3 | 281 | ❗ | | Fulfillment | 10 | 0 | 92 | 0 | 102 | ✅ | | Analytics | 9 | 0 | 0 | 0 | 9 | ✅ | | Govern | 393 | 0 | 16 | 3 | 409 | ❗ | | Configure | 1 | 0 | 12 | 0 | 13 | ✅ | | Verify | 200 | 0 | 20 | 3 | 220 | ❗ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Plan | 328 | 0 | 13 | 0 | 341 | ✅ | | Release | 20 | 0 | 4 | 0 | 24 | ✅ | | Secure | 8 | 0 | 4 | 0 | 12 | ✅ | | Data Stores | 151 | 0 | 3 | 0 | 154 | ✅ | | Monitor | 48 | 0 | 9 | 0 | 57 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 1 | 3 | ❗ | | Framework sanity | 0 | 0 | 6 | 0 | 6 | ➖ | | ModelOps | 0 | 0 | 8 | 0 | 8 | ➖ | | Growth | 0 | 0 | 8 | 0 | 8 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2149 | 0 | 356 | 11 | 2505 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+e2e-review-qa:
✅ test report for 7e1127ffexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 3 | 0 | 0 | 0 | 3 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 4 | 0 | 24 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+Edited by Ghost User🛠 Generated bygitlab_quality-test_tooling.♻ Please share your feedback and suggestions.
🐌 Slow tests detected in this merge request, might be related with changed RSpec files.Job File Name Duration Expected duration #5364352895 ee/spec/lib/quality/seeders/vulnerabilities_spec.rb#L11Quality::Seeders::Vulnerabilities when project has members creates expected number of vulnerabilities 30.02 s < 27.12 s #5364352890 ee/spec/models/ee/group_spec.rb#L701Group#vulnerability_reads returns vulnerabilities for projects in the group and its subgroups 51.88 s < 45.4 s #5372175069 ee/spec/lib/quality/seeders/vulnerabilities_spec.rb#L11Quality::Seeders::Vulnerabilities when project has members creates expected number of vulnerabilities 33.21 s < 27.12 s #5372175076 ee/spec/models/ee/group_spec.rb#L701Group#vulnerability_reads returns vulnerabilities for projects in the group and its subgroups 66.14 s < 45.4 s #5384820676 ee/spec/models/ee/group_spec.rb#L701Group#vulnerability_reads returns vulnerabilities for projects in the group and its subgroups 54.05 s < 45.4 s #5384820657 ee/spec/lib/quality/seeders/vulnerabilities_spec.rb#L11Quality::Seeders::Vulnerabilities when project has members creates expected number of vulnerabilities 32.06 s < 27.12 s #5384820704 ee/spec/lib/quality/seeders/vulnerabilities_spec.rb#L11Quality::Seeders::Vulnerabilities when project has members creates expected number of vulnerabilities 31.89 s < 27.12 s #5384820721 ee/spec/models/ee/group_spec.rb#L701Group#vulnerability_reads returns vulnerabilities for projects in the group and its subgroups 50.97 s < 45.4 s #5397579011 ee/spec/models/ee/group_spec.rb#L701Group#vulnerability_reads returns vulnerabilities for projects in the group and its subgroups 61.03 s < 45.4 s #5397579053 ee/spec/lib/quality/seeders/vulnerabilities_spec.rb#L11Quality::Seeders::Vulnerabilities when project has members creates expected number of vulnerabilities 28.94 s < 27.12 s #5397579059 ee/spec/models/ee/group_spec.rb#L701Group#vulnerability_reads returns vulnerabilities for projects in the group and its subgroups 56.34 s < 45.4 s #5397578688 spec/features/dashboard/activity_spec.rb#L190Dashboard > Activity event filters user see selected event after page reloading 64.31 s < 50.13 s #5397579012 ee/spec/lib/quality/seeders/vulnerabilities_spec.rb#L11Quality::Seeders::Vulnerabilities when project has members creates expected number of vulnerabilities 33.17 s < 27.12 s #5435328877 ee/spec/models/ee/group_spec.rb#L702Group#vulnerability_reads returns vulnerabilities for projects in the group and its subgroups 51.14 s < 45.4 s #5435328911 ee/spec/lib/quality/seeders/vulnerabilities_spec.rb#L11Quality::Seeders::Vulnerabilities when project has members creates expected number of vulnerabilities 30.24 s < 27.12 s #5435328956 ee/spec/lib/quality/seeders/vulnerabilities_spec.rb#L11Quality::Seeders::Vulnerabilities when project has members creates expected number of vulnerabilities 30.06 s < 27.12 s Edited by Ghost User- A deleted user
added rspec:slow test detected label
