Skip to content

Update inline findings Drawer

Jannik Lehmann requested to merge jnnkl-cq-inline-drawer into master

What does this MR do and why?

This MR is meant to solve: #393046 (closed) and #422545 (closed) It displays the available data for the inline findings (SAST and CodeQuality) in the findings drawer.

Screenshots or screen recordings

SAST

After Design
Screenshot_2023-11-07_at_09.05.01 Changes_-_SAST_drawer

Code Quality

After Design
Screenshot_2023-11-07_at_09.05.11 Changes_-_code_quality_drawer

How to set up and validate locally

  1. Enable sast_reports_in_inline_diff
  2. Make sure your running an ultimate license or your GDK (how to)
  3. Clone this repo: https://gitlab.com/jannik_lehmann/sast-inline-findings-example
  4. Recreate this MR for SAST & CodeQuality findings: jannik_lehmann/cq-and-sast-test!5 (diffs)
  5. Let the pipeline finish and the go checkout the diff page.
  6. Click an inline finding that opens up the detail-drawer

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Jannik Lehmann

Merge request reports