Iteration 2.2.1: [Frontend Issue] Open more info drawer from SAST Inline-diff indicator
Demo Screenshot |
---|
Related Design Issue: #415112[Changes_-_SAST_drawer.png]
Expected Behaviour
- On click of a SAST Inline Finding
- A drawer should be opened with the exact same features the SAST MR Widget Drawer/Modal has
Implementation Plan
- A basic implementation of the Drawer is already implemented, (details and reproduction)
- Use the reusable Finding Detail drawer Component from the SAST MR Widget to display the Drawer (
ee/app/assets/javascripts/security_dashboard/components/pipeline/vulnerability_finding_modal.vue
or (ee/app/assets/javascripts/vue_shared/security_reports/components/modal.vue
) - On click of SAST finding make the
pipelineFinding
GraphQl Query to get the information
GraphQl Query
query pipelineFinding($fullPath: ID!, $pipelineId: ID!, $uuid: String!) {
project(fullPath: $fullPath) {
id
pipeline(iid: $pipelineId) {
id
securityReportFinding(uuid: $uuid) {
id: uuid
stateComment
dismissedAt
dismissedBy {
id
name
username
webUrl
__typename
}
mergeRequest {
id
iid
webUrl
createdAt
author {
id
name
username
webUrl
__typename
}
__typename
}
issueLinks {
nodes {
id
linkType
issue {
id
iid
webUrl
createdAt
author {
id
name
username
webUrl
__typename
}
__typename
}
__typename
}
__typename
}
vulnerability {
id
stateTransitions(last: 1) {
nodes {
author {
id
name
username
webUrl
__typename
}
createdAt
comment
toState
__typename
}
__typename
}
__typename
}
__typename
}
__typename
}
__typename
}
}
Acceptance Criteria
- SAST Inline Findings Drawer opens on click of a findings list item
- matches Design & Feature Set of the drawer that opens on Click of a SAST Finding in the Secure MR Widget
Edited by Jannik Lehmann