Fix zoekt/client issues

What does this MR do and why?

This MR fixes 2 issues with ee/lib/gitlab/search/zoekt/client.rb:

1. Memoization causes shard_id to be fixed for one client instance

irb(main):038:0> Gitlab::Search::Zoekt::Client.instance.send(:node, 2).id
=> 2
irb(main):039:0> Gitlab::Search::Zoekt::Client.instance.send(:node, 1).id
=> 2

2. URI.join doesn't work correct for our new use case. If you use non-root base_url, it returns incorrect address

[30] pry(main)> URI.join('http://gitlab-gitlab-zoekt.default.svc.cluster.local:8080/nodes/gitlab-gitlab-zoekt-0.gitlab-gitlab-zoekt.default.svc.cluster.local', '/api/search')
=> #<URI::HTTP http://gitlab-gitlab-zoekt.default.svc.cluster.local:8080/api/search>

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before	After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

• I have evaluated the MR acceptance checklist for this MR.

added devopsdata stores groupglobal search sectioncore platform typebug labels

assigned to @dgruzd

added backend label

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	@alexbuijs (UTC+2, same timezone as author)	@acook.gitlab (UTC-4, 6 hours behind author)

Please check reviewer's status!

• Reviewer is available!
• Reviewer is unavailable!

Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed the description

removed backend label

@rkumar555 I believe this is ready for an initial review. Could I ask you to assign it to @terrichu after review if everything's ok? Thanks!

marked this merge request as ready

requested review from @rkumar555

changed milestone to %16.6

added workflowin review label

Allure report

allure-report-publisher generated test report!

e2e-test-on-gdk: test report for 5f7efb8f

expand test summary

+-----------------------------------------------------------------------+
|                            suites summary                             |
+------------------+--------+--------+---------+-------+-------+--------+
|                  | passed | failed | skipped | flaky | total | result |
+------------------+--------+--------+---------+-------+-------+--------+
| Create           | 40     | 0      | 6       | 0     | 46    | ✅     |
| Verify           | 20     | 0      | 0       | 0     | 20    | ✅     |
| Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
| Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
| Govern           | 45     | 0      | 3       | 0     | 48    | ✅     |
| Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
| Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
| Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
| Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
+------------------+--------+--------+---------+-------+-------+--------+
| Total            | 186    | 0      | 12      | 0     | 198   | ✅     |
+------------------+--------+--------+---------+-------+-------+--------+

added 1 commit

• 4b99af92 - Fix zoekt/client issues

Compare with previous version

added backend label

resolved all threads

added 356 commits

• 4b99af92...66f74004 - 355 commits from branch master
• 5f7efb8f - Fix zoekt/client issues

Compare with previous version

Reviewer roulette

Changes that require review have been detected!

Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

Category	Reviewer	Maintainer
backend	@sdungarwal (UTC+5.5, 3.5 hours ahead of author)	@georgekoltsov (UTC+1, 1 hour behind author)

Please check reviewer's status!

• Reviewer is available!
• Reviewer is unavailable!

Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

If needed, you can retry the danger-review job that generated this comment.

Generated by Danger

changed the description

approved this merge request

requested review from @terrichu and removed review request for @rkumar555

@rkumar555, thanks for approving this merge request.

This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.

For more info, please refer to the following links:

• rspec predictive jobs
• jest predictive jobs
• merging a merge request.

added pipeline:mr-approved label

approved this merge request

resolved all threads

merged

mentioned in commit a3cbfe26

added workflowstaging-canary label and removed workflowin review label

added workflowcanary label and removed workflowstaging-canary label

added workflowstaging label and removed workflowcanary label

added workflowproduction label and removed workflowstaging label

added workflowpost-deploy-db-staging label and removed workflowproduction label

added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label

added releasedcandidate label

mentioned in merge request kubitus-project/kubitus-installer!2601 (merged)