Use partitioned table for CommitStatus
What does this MR do and why?
changes the table names for CommitStatus
to use the routing table for ci_builds
. This change was enabled in production via gitlab-com/gl-infra/production#16387 (closed)
Screenshots or screen recordings
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #416455 (closed)
Merge request reports
Activity
changed milestone to %16.5
assigned to @mbobin
- A deleted user
added backend label
1 Warning There were no new or modified feature flag YAML files detected in this MR. If the changes here are already controlled under an existing feature flag, please add
the feature flagexists. Otherwise, if you think the changes here don't need
to be under a feature flag, please add the label feature flagskipped, and
add a short comment about why we skipped the feature flag.For guidance on when to use a feature flag, please see the documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend @partiaga
(UTC+11, 8 hours ahead of
@mbobin
)@mayra-cabrera
(UTC-6, 9 hours behind
@mbobin
)~"Verify" Reviewer review is optional for ~"Verify" @stanhu
(UTC-7, 10 hours behind
@mbobin
)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- Resolved by Marius Bobin
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
requested review from @tianwenchen
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 063826e0expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 40 | 0 | 6 | 0 | 46 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Verify | 20 | 0 | 0 | 0 | 20 | ✅ | | Govern | 47 | 0 | 1 | 0 | 48 | ✅ | | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 188 | 0 | 10 | 0 | 198 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 063826e0expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Verify | 150 | 0 | 15 | 3 | 165 | ❗ | | Create | 539 | 0 | 117 | 0 | 656 | ✅ | | Plan | 249 | 0 | 10 | 0 | 259 | ✅ | | Fulfillment | 8 | 0 | 69 | 0 | 77 | ✅ | | Data Stores | 117 | 0 | 3 | 0 | 120 | ✅ | | Govern | 303 | 0 | 12 | 6 | 315 | ❗ | | Manage | 39 | 1 | 10 | 2 | 50 | ❌ | | Package | 226 | 0 | 17 | 3 | 243 | ❗ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Configure | 1 | 0 | 9 | 0 | 10 | ✅ | | Growth | 0 | 0 | 6 | 0 | 6 | ➖ | | Release | 15 | 0 | 3 | 0 | 18 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 1 | 3 | ❗ | | Monitor | 36 | 0 | 7 | 0 | 43 | ✅ | | Analytics | 7 | 0 | 0 | 0 | 7 | ✅ | | Secure | 6 | 0 | 3 | 0 | 9 | ✅ | | Framework sanity | 0 | 0 | 5 | 0 | 5 | ➖ | | ModelOps | 0 | 0 | 6 | 0 | 6 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 1706 | 1 | 293 | 15 | 2000 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
changed milestone to %16.6
removed missed:16.4 label
- Resolved by Marius Bobin
@mbobin Thanks for the changes! LGTM! Good to see that we start using partitioned table for CommitStatus!
Edited by Tianwen Chen
@tianwenchen
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in epic &7522
removed review request for @tianwenchen
@mbobin Some end-to-end (E2E) tests should run based on the stage label.
Please start the
trigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure tests in thefollow-up-e2e:package-and-test-ee
pipeline pass before this MR is merged. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.
E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.
Once done, apply the
emoji on this comment.Team members only: for any questions or help, reach out on the internal
#quality
Slack channel.- Resolved by Laura Montemayor
@lauraX could you have a look at this in the coming days? We don't want to merge today because we need more time with the ENV flag enabled just in case it goes wrong during the night.
added pipeline:run-all-e2e label
enabled an automatic merge when the pipeline for 61cf3fcb succeeds
mentioned in commit e85cd164
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
mentioned in merge request gitlab-com/gl-infra/k8s-workloads/gitlab-com!3186 (merged)
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
Yup, sorry about that @fabiopitino , I will add labels to this and a few other MRs (you pinged me on and not)
added verify-reviewnot impacted label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2601 (merged)
mentioned in merge request !143041 (merged)