Skip to content
Snippets Groups Projects

Use partitioned table for CommitStatus

Merged Marius Bobin requested to merge 416455-cleanup into master
1 unresolved thread

What does this MR do and why?

changes the table names for CommitStatus to use the routing table for ci_builds. This change was enabled in production via gitlab-com/gl-infra/production#16387 (closed)

Screenshots or screen recordings

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #416455 (closed)

Edited by Marius Bobin

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Marius Bobin marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

    marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed

  • Marius Bobin requested review from @tianwenchen

    requested review from @tianwenchen

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :white_check_mark: test report for 063826e0

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 40     | 0      | 6       | 0     | 46    | ✅     |
    | Plan             | 55     | 0      | 0       | 0     | 55    | ✅     |
    | Verify           | 20     | 0      | 0       | 0     | 20    | ✅     |
    | Govern           | 47     | 0      | 1       | 0     | 48    | ✅     |
    | Data Stores      | 22     | 0      | 0       | 0     | 22    | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Manage           | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 188    | 0      | 10      | 0     | 198   | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for 063826e0

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Verify           | 150    | 0      | 15      | 3     | 165   | ❗     |
    | Create           | 539    | 0      | 117     | 0     | 656   | ✅     |
    | Plan             | 249    | 0      | 10      | 0     | 259   | ✅     |
    | Fulfillment      | 8      | 0      | 69      | 0     | 77    | ✅     |
    | Data Stores      | 117    | 0      | 3       | 0     | 120   | ✅     |
    | Govern           | 303    | 0      | 12      | 6     | 315   | ❗     |
    | Manage           | 39     | 1      | 10      | 2     | 50    | ❌     |
    | Package          | 226    | 0      | 17      | 3     | 243   | ❗     |
    | Systems          | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Configure        | 1      | 0      | 9       | 0     | 10    | ✅     |
    | Growth           | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Release          | 15     | 0      | 3       | 0     | 18    | ✅     |
    | GitLab Metrics   | 2      | 0      | 1       | 1     | 3     | ❗     |
    | Monitor          | 36     | 0      | 7       | 0     | 43    | ✅     |
    | Analytics        | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Secure           | 6      | 0      | 3       | 0     | 9     | ✅     |
    | Framework sanity | 0      | 0      | 5       | 0     | 5     | ➖     |
    | ModelOps         | 0      | 0      | 6       | 0     | 6     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 1706   | 1      | 293     | 15    | 2000  | ❌     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Marius Bobin changed milestone to %16.6

    changed milestone to %16.6

  • removed missed:16.4 label

  • Tianwen Chen approved this merge request

    approved this merge request

  • :wave: @tianwenchen, thanks for approving this merge request.

    This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Marius Bobin mentioned in epic &7522

    mentioned in epic &7522

  • Tianwen Chen removed review request for @tianwenchen

    removed review request for @tianwenchen

  • Contributor

    @mbobin Some end-to-end (E2E) tests should run based on the stage label.

    Please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and ensure tests in the follow-up-e2e:package-and-test-ee pipeline pass before this MR is merged. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)

    To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.

    E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.

    Once done, apply the :white_check_mark: emoji on this comment.

    Team members only: for any questions or help, reach out on the internal #quality Slack channel.

    • Author Maintainer
      Resolved by Laura Montemayor

      @lauraX could you have a look at this in the coming days? We don't want to merge today because we need more time with the ENV flag enabled just in case it goes wrong during the night.

  • Marius Bobin requested review from @lauraX

    requested review from @lauraX

  • Laura Montemayor approved this merge request

    approved this merge request

  • Laura Montemayor resolved all threads

    resolved all threads

  • Laura Montemayor enabled an automatic merge when the pipeline for 61cf3fcb succeeds

    enabled an automatic merge when the pipeline for 61cf3fcb succeeds

  • Laura Montemayor mentioned in commit e85cd164

    mentioned in commit e85cd164

  • added workflowstaging label and removed workflowcanary label

  • Max Orefice mentioned in merge request !143041 (merged)

    mentioned in merge request !143041 (merged)

  • Please register or sign in to reply
    Loading