Make dark mode label text and remove label buttons the same color
requested to merge 428092-when-in-dark-mode-labels-do-not-have-appropriate-text-contrast-and-remove-label-buttons into master
What does this MR do and why?
Currently in dark mode, non-scoped labels that have a remove button will have different colored label text and remove buttons. This MR makes them both the same color.
CAVEAT: there are still problems in #428092 with accessible color contrast and scoped labels that are NOT ADDRESSED in this MR.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
 |
 |
How to set up and validate locally
- start your local gdk
- if your local gdk user is not already using dark mode, go to
http://gdk.test:3000/-/profile/preferencesand turn on dark mode - navigate to an issue with labels. You will observe that their text color and remove button color do not match
- in the terminal, navigate to the gitlab directory in the gdk and check out this branch
- when the changes in this branch are available in the dom, you will see that the labels on the issue have text and remove buttons that are the same color
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #428092
Edited by Chad Lavimoniere