Enable multiple pages jobs
What does this MR do and why?
As part of the introduction of the GitLab Pages Multiple Versions support we need to permit users to create multiple pages jobs.
Users now can create jobs either named pages
or use the pages:
job
option to start a new Pages job. This new option is a hash that accepts
enabled
(boolean) and path_prefix:
(string).
This also replaces the pages_path_prefix
option.
jobname:
pages:
enabled: true
path_prefix: 'prefix' # when using multiple versions
Related to: #427755 (closed)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.5
assigned to @kassio
- A deleted user
added backend documentation labels
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend jpcyiza
(UTC+2, 1 hour ahead of
@kassio
)felipe_artur
(UTC-3, 4 hours behind
@kassio
)frontend dstull
(UTC-4, 5 hours behind
@kassio
)himkp
(UTC+2, 1 hour ahead of
@kassio
)~"Verify" Reviewer review is optional for ~"Verify" drew
(UTC+0, 1 hour behind
@kassio
)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost UserAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 68f743d0expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 33 | 0 | 0 | 0 | 33 | ✅ | | Plan | 55 | 0 | 0 | 0 | 55 | ✅ | | Create | 32 | 0 | 5 | 0 | 37 | ✅ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 12 | 0 | 1 | 0 | 13 | ✅ | | Data Stores | 18 | 0 | 2 | 0 | 20 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 158 | 0 | 8 | 0 | 166 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 68f743d0expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Plan | 54 | 0 | 1 | 0 | 55 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Data Stores | 1 | 0 | 1 | 0 | 2 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 70 | 0 | 5 | 0 | 75 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Useradded 39 commits
-
6d25ded2...60fde97a - 38 commits from branch
master
- 4eb05300 - Enable multiple pages jobs
-
6d25ded2...60fde97a - 38 commits from branch
added pipeline:run-all-rspec label
added 374 commits
-
2cd0e302...a59fad6c - 373 commits from branch
master
- 107f8175 - Enable multiple pages jobs
-
2cd0e302...a59fad6c - 373 commits from branch
requested review from @kassio
removed review request for @kassio
- Resolved by Kassio Borges
@mfanGitLab, could you do the backend review of this one, please?
requested review from @mfanGitLab
- Resolved by Kassio Borges
@drew, could you do the ~Verify review of this one, please?
requested review from @drew