Skip to content

Improve vulnerability details button layout

Lorenz van Herwaarden requested to merge improve-vulnerability-detail-button-layout into master

What does this MR do and why?

Slightly improves spacing between vulnerability state dropdown and actions dropdown so it aligns with the default spacing between buttons of Pajamas.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
before after

How to set up and validate locally

Prerequisites

  1. You need an EE license
  2. You need to have runners enabled (See $2408961 for setting up a runner)
  3. Import https://gitlab.com/gitlab-examples/security/security-reports
  4. Run a pipeline on master

Validate

  1. Go to a security-reports vulnerability report
  2. Filter on container scanning in the tool filter
  3. Go to the details of any vulnerability
  4. Validate that the spacing between the status dropdown button and the action dropdown button is 0.5rem (larger than before)
  5. Validate that the center alignment is slightly improved to before

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lorenz van Herwaarden

Merge request reports