Skip to content

Migrate split_button to button group with Listbox

Lorenz van Herwaarden requested to merge migrate-split-button-vulnerability-modal into master

What does this MR do and why?

Migrate split_button to button group with Listbox

  • Migrate split GlDropdown to GlButtonGroup with a GlButton and a GlCollapsibleListbox.
  • Update the specs accordingly.

Related to #418062 (closed)

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-10-05_at_10.21.30 Screenshot_2023-10-05_at_10.21.07
Screenshot_2023-10-05_at_10.21.35 Screenshot_2023-10-05_at_10.21.13

How to set up and validate locally

Prerequisites

  1. You need an EE license
  2. You need to have runners enabled (See $2408961 for setting up a runner)
  3. Import https://gitlab.com/gitlab-examples/security/security-reports
  4. Run a pipeline on master

Validate

  1. Go to a security-reports pipeline and to security tab
  2. Filter on tool: Container scanning
  3. Click on one of the findings
  4. Select different options in the split button and check it updates the button text

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lorenz van Herwaarden

Merge request reports