Add API for creating amazon_s3_configurations for audit event streaming
What does this MR do and why?
Add API for creating amazon_s3_configurations for audit event streaming
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
- Visit GraphiQL explorer https://gdk.test:3000/-/graphql-explorer
- Run the following mutation to create a new
AuditEvents::AmazonS3Configuration
mutation createAmazonS3Configuration {
amazonS3ConfigurationCreate(
input: {groupPath: "twitter", awsRegion: "us-east-1", accessKeyXid: "AKIA1231dsdsdsdsds23", secretAccessKey: "TOPSECRET", bucketName: "TEST"}
) {
amazonS3Configuration {
id
name
accessKeyXid
bucketName
awsRegion
}
errors
}
}
- Run the following in rails console and verify that a new record was created with correct attributes
AuditEvents::AmazonS3Configuration.last
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Relates to #423229 (closed)
Merge request reports
Activity
changed milestone to %16.5
added GraphQL backend featureaddition groupcompliance labels
assigned to @huzaifaiftikhar1
added typefeature label
added devopsgovern sectionsec labels
- A deleted user
added documentation label
1 Warning 7008f164: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/administration/audit_event_streaming/audit_event_types.md
(Link to current live version) -
doc/api/graphql/reference/index.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Michael Becker (
@wandering_person
) (UTC+7, 1.5 hours ahead of@huzaifaiftikhar1
)Felipe Artur (
@felipe_artur
) (UTC-3, 8.5 hours behind@huzaifaiftikhar1
)frontend Nataliia Radina (
@nradina
) (UTC+2, 3.5 hours behind@huzaifaiftikhar1
)Andrew Fontaine (
@afontaine
) (UTC-4, 9.5 hours behind@huzaifaiftikhar1
)groupcompliance Reviewer review is optional for groupcompliance Aaron Huntsman (
@ahuntsman
) (UTC-5, 10.5 hours behind@huzaifaiftikhar1
)Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger-
removed documentation label
@aakriti.gupta Can you please perform the initial backend review and pass it to
@harsimarsandhu
for backend maintainer and groupcompliance domain expert review?requested review from @aakriti.gupta
mentioned in issue #423229 (closed)
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 50adea01expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Manage | 12 | 0 | 1 | 0 | 13 | ✅ | | Create | 37 | 0 | 1 | 0 | 38 | ✅ | | Plan | 51 | 0 | 0 | 0 | 51 | ✅ | | Govern | 35 | 0 | 1 | 0 | 36 | ✅ | | Data Stores | 18 | 0 | 2 | 0 | 20 | ✅ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 161 | 0 | 5 | 0 | 166 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 50adea01expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 34 | 0 | 1 | 0 | 35 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Create | 8 | 0 | 1 | 2 | 9 | ❗ | | Data Stores | 1 | 0 | 1 | 0 | 2 | ✅ | | Monitor | 4 | 0 | 0 | 1 | 4 | ❗ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 51 | 0 | 6 | 3 | 57 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- 46187330 - Add API for creating amazon_s3_configurations for audit event streaming
- A deleted user
added documentation frontend labels
- Resolved by Simon Knox
requested review from @psimyn
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits b2a34159 and 50adea01
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.23 MB 4.23 MB - 0.0 % mainChunk 3.1 MB 3.1 MB - 0.0 %
Note: We do not have exact data for b2a34159. So we have used data from: 8695d18a.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
Dangermentioned in issue #422318 (closed)
@psimyn
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
@huzaifaiftikhar1 Some end-to-end (E2E) tests should run based on the stage label.
Please start the
trigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure tests in thefollow-up-e2e:package-and-test-ee
pipeline pass before this MR is merged. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.
E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.
Once done, apply the
emoji on this comment.Team members only: for any questions or help, reach out on the internal
#quality
Slack channel.- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
- Resolved by Huzaifa Iftikhar
Hey! In my limited experience with GraphQL this change is good, the tests are adequate. I have left a couple of small comments only.
Feel free to assign for a maintainer review, after addressing them.
removed review request for @aakriti.gupta
removed review request for @psimyn
requested review from @harsimarsandhu
added 1 commit
- 50adea01 - Remove secret_access_key from GraphQL API response
- Resolved by Huzaifa Iftikhar
removed review request for @harsimarsandhu
requested review from @harsimarsandhu
removed review request for @harsimarsandhu
enabled an automatic merge when the pipeline for c93e6665 succeeds
- Resolved by Huzaifa Iftikhar
@huzaifaiftikhar1, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
mentioned in commit 1c40ebd9
requested review from @harsimarsandhu
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2517 (merged)