Skip to content
Snippets Groups Projects

Add API for creating amazon_s3_configurations for audit event streaming

All threads resolved!

What does this MR do and why?

Add API for creating amazon_s3_configurations for audit event streaming

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

  1. Visit GraphiQL explorer https://gdk.test:3000/-/graphql-explorer
  2. Run the following mutation to create a new AuditEvents::AmazonS3Configuration
mutation createAmazonS3Configuration {
  amazonS3ConfigurationCreate(
    input: {groupPath: "twitter", awsRegion: "us-east-1", accessKeyXid: "AKIA1231dsdsdsdsds23", secretAccessKey: "TOPSECRET", bucketName: "TEST"}
  ) {
    amazonS3Configuration {
      id
      name
      accessKeyXid
      bucketName
      awsRegion
    }
    errors
  }
}
  1. Run the following in rails console and verify that a new record was created with correct attributes
AuditEvents::AmazonS3Configuration.last

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Relates to #423229 (closed)

Edited by Huzaifa Iftikhar

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @psimyn Can you please review this as frontend maintainer? The frontend review is required only for the file app/assets/javascripts/graphql_shared/possible_types.json and that too is auto generated, therefore, directly seeking maintainer review.

  • Huzaifa Iftikhar requested review from @psimyn

    requested review from @psimyn

  • Contributor

    Bundle size analysis [beta]

    This compares changes in bundle size for entry points between the commits b2a34159 and 50adea01

    :sparkles: Special assets

    Entrypoint / Name Size before Size after Diff Diff in percent
    average 4.23 MB 4.23 MB - 0.0 %
    mainChunk 3.1 MB 3.1 MB - 0.0 %

    Note: We do not have exact data for b2a34159. So we have used data from: 8695d18a.
    The intended commit has no webpack pipeline, so we chose the last commit with one before it.

    Please look at the full report for more details


    Read more about how this report works.

    Generated by :no_entry_sign: Danger

  • mentioned in issue #422318 (closed)

  • Simon Knox resolved all threads

    resolved all threads

  • Simon Knox approved this merge request

    approved this merge request

  • :wave: @psimyn, thanks for approving this merge request.

    This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Contributor

    @huzaifaiftikhar1 Some end-to-end (E2E) tests should run based on the stage label.

    Please start the trigger-omnibus-and-follow-up-e2e job in the qa stage and ensure tests in the follow-up-e2e:package-and-test-ee pipeline pass before this MR is merged. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)

    To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.

    E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.

    Once done, apply the :white_check_mark: emoji on this comment.

    Team members only: for any questions or help, reach out on the internal #quality Slack channel.

  • Aakriti Gupta approved this merge request

    approved this merge request

  • Aakriti Gupta removed review request for @aakriti.gupta

    removed review request for @aakriti.gupta

  • Simon Knox removed review request for @psimyn

    removed review request for @psimyn

  • added 1 commit

    Compare with previous version

  • requested review from @harsimarsandhu

  • added 1 commit

    • 50adea01 - Remove secret_access_key from GraphQL API response

    Compare with previous version

  • Huzaifa Iftikhar changed the description

    changed the description

  • Harsimar Sandhu
  • Harsimar Sandhu removed review request for @harsimarsandhu

    removed review request for @harsimarsandhu

  • requested review from @harsimarsandhu

  • Harsimar Sandhu approved this merge request

    approved this merge request

  • Harsimar Sandhu removed review request for @harsimarsandhu

    removed review request for @harsimarsandhu

  • Huzaifa Iftikhar resolved all threads

    resolved all threads

  • Huzaifa Iftikhar enabled an automatic merge when the pipeline for c93e6665 succeeds

    enabled an automatic merge when the pipeline for c93e6665 succeeds

  • Huzaifa Iftikhar mentioned in commit 1c40ebd9

    mentioned in commit 1c40ebd9

  • Huzaifa Iftikhar resolved all threads

    resolved all threads

  • requested review from @harsimarsandhu

  • added workflowstaging label and removed workflowcanary label

  • Please register or sign in to reply
    Loading