Skip to content

Fix organization sidebar header and add pinning support

Peter Hegman requested to merge fix-organization-sidebar into master

What does this MR do and why?

Navigation approval request: #417778 (closed)

In !129843 (merged) we adjusted how the sidebar header looks and this caused a minor bug in the organization sidebar. Not a big deal because organizations are in early development and behind the ui_for_organizations feature flag. For more information about organizations see Organization MVC for Cells (&10649) and https://docs.gitlab.com/ee/user/organization/

This MR fixes the sidebar bug. It also adds support for pinning because the original designs have pinning and it was pointed out that the new header style looks better with pinning under it.

For now there is only one navigation item but there will be more as we continue to build organizations.

Screenshots or screen recordings

Before After
Screenshot_2023-09-07_at_3.35.48_PM Screenshot_2023-09-07_at_3.35.18_PM

How to set up and validate locally

  1. Open Rails console
    • bin/rails console
  2. Enable the feature flag
    • Feature.enable(:ui_for_organizations)
  3. Navigate to /-/organizations/default
  4. The sidebar should look correct and pinning should work

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Peter Hegman

Merge request reports