Remove gdk base image and pin gdk sha
What does this MR do and why?
Port changes for gdk build which pin explicit versions of gdk base image and gdk commit sha
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @acunskis
- A deleted user
added QA label
- Resolved by Nao Hashizume
2 Warnings The e2e:package-and-test-ee
job needs to succeed or have approval from a Software Engineer in Test.
Read the "QA e2e:package-and-test-ee" section for more details.Please add a merge request subtype to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Pipeline Changes
This merge request contains changes to the pipeline configuration for the GitLab project.
Please consider the effect of the changes in this merge request on the following:
- Effects on different pipeline types
- Effects on non-canonical projects:
gitlab-foss
security
dev
- personal forks
- Effects on pipeline performance
Please consider communicating these changes to the broader team following the communication guideline for pipeline changes
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer QA Zeff Morgan (
@zeffmorgan
) (UTC+0, 3 hours behind@acunskis
)Dan Davison (
@ddavison
) (UTC-4, 7 hours behind@acunskis
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
QA
e2e:package-and-test-ee
@acunskis, the
package-and-test
job must complete before merging this merge request.*If there are failures on the
package-and-test
pipeline, ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the#quality
Slack channel.If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger
changed milestone to %16.4
- Resolved by Nao Hashizume
@nao.hashizume Could You please take a look at these backported changes to gdk build. It should allow us to re-enable gdk without breaking backport pipelines (well, hopefully, I'm not sure if the current problems don't affect older stable branches)
requested review from @nao.hashizume
Allure report
allure-report-publisher
generated test report!e2e-review-qa:
test report for 894b71a2expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 20 | 0 | 4 | 0 | 24 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 894b71a2expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 558 | 1 | 89 | 28 | 648 | ❌ | | Manage | 158 | 1 | 12 | 7 | 171 | ❌ | | Plan | 246 | 0 | 10 | 0 | 256 | ✅ | | Monitor | 36 | 0 | 7 | 0 | 43 | ✅ | | Package | 226 | 0 | 17 | 12 | 243 | ❗ | | Data Stores | 117 | 0 | 3 | 3 | 120 | ❗ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Framework sanity | 0 | 0 | 5 | 0 | 5 | ➖ | | Verify | 144 | 0 | 15 | 0 | 159 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Fulfillment | 8 | 0 | 72 | 0 | 80 | ✅ | | Analytics | 7 | 0 | 0 | 0 | 7 | ✅ | | Govern | 164 | 0 | 6 | 6 | 170 | ❗ | | Release | 18 | 0 | 0 | 0 | 18 | ✅ | | Configure | 1 | 0 | 9 | 0 | 10 | ✅ | | ModelOps | 0 | 0 | 6 | 0 | 6 | ➖ | | Growth | 0 | 0 | 6 | 0 | 6 | ➖ | | Secure | 6 | 0 | 12 | 0 | 18 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 1699 | 2 | 270 | 56 | 1971 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
added typebug label and removed typemaintenance label
removed maintenancepipelines label
- Resolved by Nao Hashizume
@nao.hashizume
, thanks for approving this merge request.This is the first time the merge request has been approved. Please ensure the
e2e:package-and-test-ee
job has succeeded. If there is a failure, a Software Engineer in Test (SET) needs to confirm the failures are unrelated to the merge request. If there's no SET assigned to this team, ask for assistance on the#quality
Slack channel.
- Resolved by Andrejs Cunskis
The
danger-review
job failed with the following error, but thee2e:package-and-test-ee
job succeeded here: https://gitlab.com/gitlab-org/gitlab/-/pipelines/995712636.Errors: - [ ] The `e2e:package-and-test-ee` job is not present, has been canceled, or needs to be automatically triggered. Please ensure the job is present in the latest pipeline, if necessary, retry the `danger-review` job. Read the "QA e2e:package-and-test-ee" section for more details.
I retried the
e2e:package-and-test-ee
job now: https://gitlab.com/gitlab-org/gitlab/-/pipelines/996590056.
- Resolved by Dan Davison
Hi @ddavison, could you please do maintainer review? Thanks in advance!
requested review from @ddavison
mentioned in issue #424404 (closed)