Skip to content
Snippets Groups Projects

Remove gdk base image and pin gdk sha

Merged Andrejs Cunskis requested to merge andrey-gdk-build-improvements into 16-3-stable-ee

What does this MR do and why?

Port changes for gdk build which pin explicit versions of gdk base image and gdk commit sha

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • A deleted user added QA label

    added QA label

    • Contributor
      Resolved by Nao Hashizume
      2 Warnings
      :warning: The e2e:package-and-test-ee job needs to succeed or have approval from a Software Engineer in Test.
      Read the "QA e2e:package-and-test-ee" section for more details.
      :warning: Please add a merge request subtype to this merge request.
      1 Message
      :book: CHANGELOG missing:

      If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

      If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

      If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

      Pipeline Changes

      This merge request contains changes to the pipeline configuration for the GitLab project.

      Please consider the effect of the changes in this merge request on the following:

      Please consider communicating these changes to the broader team following the communication guideline for pipeline changes

      Reviewer roulette

      Changes that require review have been detected!

      Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

      Category Reviewer Maintainer
      QA Zeff Morgan current availability (@zeffmorgan) (UTC+0, 3 hours behind @acunskis) Dan Davison current availability (@ddavison) (UTC-4, 7 hours behind @acunskis)

      To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

      To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

      Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

      QA e2e:package-and-test-ee

      @acunskis, the package-and-test job must complete before merging this merge request.*

      If there are failures on the package-and-test pipeline, ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the #quality Slack channel.

      If needed, you can retry the :repeat: danger-review job that generated this comment.

      Generated by :no_entry_sign: Danger

  • Andrejs Cunskis changed milestone to %16.4

    changed milestone to %16.4

  • Andrejs Cunskis added 1 commit

    added 1 commit

    Compare with previous version

  • requested review from @nao.hashizume

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-review-qa: :white_check_mark: test report for 894b71a2

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 8      | 0      | 1       | 0     | 9     | ✅     |
    | Plan             | 3      | 0      | 1       | 0     | 4     | ✅     |
    | Manage           | 1      | 0      | 0       | 0     | 1     | ✅     |
    | Monitor          | 4      | 0      | 0       | 0     | 4     | ✅     |
    | Data Stores      | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Govern           | 2      | 0      | 0       | 0     | 2     | ✅     |
    | Framework sanity | 0      | 0      | 1       | 0     | 1     | ➖     |
    | Package          | 0      | 0      | 1       | 0     | 1     | ➖     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 20     | 0      | 4       | 0     | 24    | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :x: test report for 894b71a2

    expand test summary
    +-----------------------------------------------------------------------+
    |                            suites summary                             |
    +------------------+--------+--------+---------+-------+-------+--------+
    |                  | passed | failed | skipped | flaky | total | result |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Create           | 558    | 1      | 89      | 28    | 648   | ❌     |
    | Manage           | 158    | 1      | 12      | 7     | 171   | ❌     |
    | Plan             | 246    | 0      | 10      | 0     | 256   | ✅     |
    | Monitor          | 36     | 0      | 7       | 0     | 43    | ✅     |
    | Package          | 226    | 0      | 17      | 12    | 243   | ❗     |
    | Data Stores      | 117    | 0      | 3       | 3     | 120   | ❗     |
    | Systems          | 8      | 0      | 0       | 0     | 8     | ✅     |
    | Framework sanity | 0      | 0      | 5       | 0     | 5     | ➖     |
    | Verify           | 144    | 0      | 15      | 0     | 159   | ✅     |
    | GitLab Metrics   | 2      | 0      | 1       | 0     | 3     | ✅     |
    | Fulfillment      | 8      | 0      | 72      | 0     | 80    | ✅     |
    | Analytics        | 7      | 0      | 0       | 0     | 7     | ✅     |
    | Govern           | 164    | 0      | 6       | 6     | 170   | ❗     |
    | Release          | 18     | 0      | 0       | 0     | 18    | ✅     |
    | Configure        | 1      | 0      | 9       | 0     | 10    | ✅     |
    | ModelOps         | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Growth           | 0      | 0      | 6       | 0     | 6     | ➖     |
    | Secure           | 6      | 0      | 12      | 0     | 18    | ✅     |
    +------------------+--------+--------+---------+-------+-------+--------+
    | Total            | 1699   | 2      | 270     | 56    | 1971  | ❌     |
    +------------------+--------+--------+---------+-------+-------+--------+
  • Nao Hashizume added typebug label and removed typemaintenance label

    added typebug label and removed typemaintenance label

  • Nao Hashizume approved this merge request

    approved this merge request

  • Nao Hashizume resolved all threads

    resolved all threads

    • Resolved by Nao Hashizume

      :wave: @nao.hashizume, thanks for approving this merge request.

      This is the first time the merge request has been approved. Please ensure the e2e:package-and-test-ee job has succeeded. If there is a failure, a Software Engineer in Test (SET) needs to confirm the failures are unrelated to the merge request. If there's no SET assigned to this team, ask for assistance on the #quality Slack channel.

  • Nao Hashizume resolved all threads

    resolved all threads

  • Nao Hashizume requested review from @ddavison

    requested review from @ddavison

  • mentioned in issue #424404 (closed)

  • Nao Hashizume resolved all threads

    resolved all threads

Please register or sign in to reply
Loading