Skip to content
Snippets Groups Projects

Add no_super_sidebar trait to CE specs (1/2)

Merged Lukas Eipert requested to merge leipert-no_super_sidebar_ce_one into master
All threads resolved!

What does this MR do and why?

Add no_super_sidebar trait to CE specs

We are adding the no_super_sidebar trait to CE specs that rely on the old-nav behavior. See:


Related:

Screenshots or screen recordings

N/A

How to set up and validate locally

Passing specs

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lukas Eipert

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
  • Ghost User
  • Ghost User
  • Ghost User
  • Ghost User
  • Ghost User
  • Ghost User
  • Contributor

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    test for spec/features/* Sanad Liaquat current availability (@sliaquat) (UTC+5, 3 hours ahead of @leipert) Maintainer review is optional for test for spec/features/*

    Please check reviewer's status!

    • available Reviewer is available!
    • unavailable Reviewer is unavailable!

    Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Lukas Eipert mentioned in merge request !130302 (merged)

    mentioned in merge request !130302 (merged)

  • Lukas Eipert changed the description

    changed the description

  • Lukas Eipert mentioned in merge request !130151 (merged)

    mentioned in merge request !130151 (merged)

  • Lukas Eipert mentioned in merge request !126175 (merged)

    mentioned in merge request !126175 (merged)

  • Lukas Eipert resolved all threads

    resolved all threads

  • Lukas Eipert requested review from @sliaquat

    requested review from @sliaquat

  • Lukas Eipert added 1 commit

    added 1 commit

    • dc69c5d9 - Add no_super_sidebar trait to CE specs

    Compare with previous version

  • Sanad Liaquat
  • Sanad Liaquat approved this merge request

    approved this merge request

  • :wave: @sliaquat, thanks for approving this merge request.

    This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Sanad Liaquat resolved all threads

    resolved all threads

  • Sanad Liaquat resolved all threads

    resolved all threads

  • Sanad Liaquat enabled an automatic merge when the pipeline for 671c09d3 succeeds

    enabled an automatic merge when the pipeline for 671c09d3 succeeds

  • Sanad Liaquat canceled the automatic merge

    canceled the automatic merge

  • Sanad Liaquat enabled an automatic merge when the pipeline for 671c09d3 succeeds

    enabled an automatic merge when the pipeline for 671c09d3 succeeds

  • merged

  • Sanad Liaquat mentioned in commit a9fa5e48

    mentioned in commit a9fa5e48

  • Lukas Eipert mentioned in commit d861eac5

    mentioned in commit d861eac5

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #420121 (closed)

  • Please register or sign in to reply
    Loading