Add no_super_sidebar trait to CE specs (1/2)
What does this MR do and why?
Add no_super_sidebar trait to CE specs
We are adding the no_super_sidebar trait to CE specs that rely on the old-nav behavior. See:
Related:
- Add no_super_sidebar trait to EE specs (!130151 - merged)
- Add no_super_sidebar trait to CE specs (2/2) (!130302 - merged)
Screenshots or screen recordings
N/A
How to set up and validate locally
Passing specs
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @leipert
changed milestone to %16.4
removed frontend label
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
- Resolved by Lukas Eipert
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer test for spec/features/*
Sanad Liaquat (
@sliaquat
) (UTC+5, 3 hours ahead of@leipert
)Maintainer review is optional for test for spec/features/*
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in merge request !130302 (merged)
mentioned in merge request !130151 (merged)
mentioned in merge request !126175 (merged)
- Resolved by Sanad Liaquat
@sliaquat Good things come in threes. And this is the third one! Could you please review this one as well? Thank you!
Basically this adds a trait to the users in certain specs in order to force the old nav.
Quick links to the other MRs: !130151 (merged) / !130302 (merged)
requested review from @sliaquat
- Resolved by Sanad Liaquat
@sliaquat
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
enabled an automatic merge when the pipeline for 671c09d3 succeeds
enabled an automatic merge when the pipeline for 671c09d3 succeeds
mentioned in commit a9fa5e48
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
mentioned in commit d861eac5
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
mentioned in issue #420121 (closed)
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in issue gitlab-org/manage/foundations/team-tasks#295
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label