Skip to content

Introduce no_super_sidebar trait in specs

Lukas 'ai-pi' Eipert requested to merge leipert-rspec-add-no-super-sidebar-trait into master

What does this MR do and why?

We are planning to make the super sidebar navigation the default navigation. Unfortunately we currently rely on the old navigation behavior in more than 150 spec files. Currently the old navigation is used in all specs. The plan is to:

  1. Introduce a user specific trait (this commit) and move from a global "old"-nav switch to a per-test switch.
  2. Remove the global feature flag toggle (!126175 (merged))
  3. Fix all tests to work with the new nav: #420121 (closed)
  4. Remove the trait.

This commit additionally adds the trait to a few specs in order to show that it doesn't break anything:

  • a few navigation related specs (navbar_spec.rb)
  • a few fixtures which otherwise break jest specs
  • a few shared examples and related specs

Screenshots or screen recordings

N/A

How to set up and validate locally

  1. Have a look at the MR: !126175 (merged) which includes all the changes in this MR and then some
  2. Passing specs

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Lukas 'ai-pi' Eipert

Merge request reports