Remove feature flag `product_analytics_snowplow_support`
What does this MR do and why?
Removal of the product_analytics_snowplow_support
feature flag as it's no longer needed
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #403418 (closed)
Merge request reports
Activity
changed milestone to %Backlog
assigned to @acook.gitlab
- Resolved by Matthias Käppler
@acook.gitlab - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request.
added 1 commit
- 97f974b8 - Remove the product_analytics_snowplow_support feature flag
added typemaintenance label
- A deleted user
added backend label
1 Warning Please add a merge request subtype to this merge request. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Aman Luthra (
@aluthra2
) (UTC+5.5, 9.5 hours ahead of@acook.gitlab
)Matthias Käppler (
@mkaeppler
) (UTC+2, 6 hours ahead of@acook.gitlab
)test for spec/features/*
Aman Luthra (
@aluthra2
) (UTC+5.5, 9.5 hours ahead of@acook.gitlab
)Maintainer review is optional for test for spec/features/*
Please check reviewer's status!
Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 2453df64expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Data Stores | 22 | 0 | 0 | 0 | 22 | ✅ | | Plan | 51 | 0 | 0 | 0 | 51 | ✅ | | Govern | 36 | 0 | 0 | 0 | 36 | ✅ | | Manage | 13 | 0 | 1 | 0 | 14 | ✅ | | Create | 46 | 0 | 1 | 2 | 47 | ❗ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 180 | 0 | 4 | 2 | 184 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 2453df64expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 157 | 0 | 20 | 13 | 177 | ❗ | | Package | 25 | 0 | 2 | 0 | 27 | ✅ | | Manage | 59 | 0 | 4 | 2 | 63 | ❗ | | Plan | 9 | 0 | 1 | 0 | 10 | ✅ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Analytics | 1 | 0 | 0 | 0 | 1 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Fulfillment | 2 | 0 | 0 | 1 | 2 | ❗ | | Monitor | 12 | 0 | 1 | 0 | 13 | ✅ | | Configure | 1 | 0 | 0 | 0 | 1 | ✅ | | Data Stores | 15 | 0 | 3 | 0 | 18 | ✅ | | Govern | 5 | 0 | 0 | 0 | 5 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 296 | 0 | 34 | 16 | 330 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@bfed12b5
- Resolved by Matthias Käppler
@serenafang could you do the first backend review of this FF removal MR?
requested review from @serenafang
@serenafang
, thanks for approving this merge request.This is the first time the merge request has been approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@8b7ad4f8
requested review from @mkaeppler and removed review request for @serenafang
changed milestone to %16.4
enabled an automatic merge when the pipeline for 71a5cf0c succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@71a5cf0c
mentioned in commit da3d33af
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2437 (merged)