Migrate security_report_download_dropdown to GlDisclosureDropdown
What does this MR do and why?
Relates to #422523 (closed)
Migrate security_report_download_dropdown to GlDisclosureDropdown
- Migrate from GlDropdown to GlDisclosureDropdown
- Remove title prop and tooltip – unused
- Simplify spec
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
|
|
How to set up and validate locally
Prerequisites
- You need an EE license
- You need to have runners enabled (See $2408961 for setting up a runner)
- Import https://gitlab.com/gitlab-examples/security/security-reports
- Run a pipeline on master
Validate
- Go to pipeline > security tab
- Expand reports by clicking "Show details" in the Scan details card
- Click on any "Download results" button
- Validate that this shows disclosure dropdown and each option can be clicked and will download the scan results
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Edited by Lorenz van Herwaarden