Refactor issues_analytics component
What does this MR do and why?
As the second of three MRs to solve #233905 (closed), this MR does the following:
- Moves the current – and soon to be deprecated once
issues_completed_analytics_feature_flag
is rolled out – Issues Analytics chart and the majority of its Vuex properties/actions into its own component. - Refactors
issues_analytics.vue
so that it functions as a base app. This will facilitate toggling between the old and new chart (coming in next MR) depending on if the user is a GitLab Ultimate customer and theissues_completed_analytics_feature_flag
FF is enabled. - Consolidates empty states in a new
IssuesAnalyticsEmptyState
component. Also moves "No data when filters applied" empty state to the correct place within the view (filters aren't currently being applied to the table – will be resolved in #422451 (closed)).
No changelog since this is a refactor.
Task | Status |
---|---|
Add issues_completed_analytics GitLab Ultimate feature and issues_completed_analytics_feature_flag feature flag ( !128399 (merged)) |
|
Refactor issues_analytics.vue
|
|
Create new chart with "Issues closed" |
Screenshots or screen recordings
State | Before | After |
---|---|---|
Default | ||
Loading | ||
No data empty state | ||
No data with filters applied empty state |
How to set up and validate locally
- Go to a group/project with issues, and visit
http://{LOCAL_INSTANCE}/groups/{GROUP_PATH}/-/issues_analytics
orhttp://{LOCAL_INSTANCE}/{GROUP_PATH}/{PROJECT_PATH}/-/analytics/issues_analytics
and verify that there are no regressions.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #233905 (closed)
Edited by Rudy Crespo