Update top-bar on new project/group pages to be fixed to top of viewport
requested to merge 415851-update-glbreadcrumb-on-create-pages-to-be-full-width-and-sticky into master
What does this MR do and why?
Update top-bar on new project/group pages to be fixed to top of viewport
- Update
<new-namespace-page>
top-bar with.top-bar-fixed
and.container-fluid
classes - Separate hiding top-bar with
@hide_top_bar
and hiding top-bar padding top on.content-wrapper
with@hide_top_bar_padding
- Update
terms.html.haml
to hide padding with@hide_top_bar_padding
Screenshots or screen recordings
New group
Before | After |
---|---|
new-group-before | new-group-after |
New project
Before | After |
---|---|
new-project-before | new-project-after |
Terms
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Review
/groups/new
with new and old navigation - Review
/projects/new
with new and old navigation - Review terms view
To view terms page:
- Login as an admin (
root
user in GDK). - Navigate to
/admin/application_settings/general
- In the Terms of Service and Privacy Policy panel:
- Check the All users must accept the Terms of Service and Privacy Policy to access GitLab checkbox
- Enter some text in the text area
- Save the form
- Navigate to
/admin/users
and choose a user. - Click Impersonate in the upper right corner.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #415851 (closed)
Edited by Scott de Jonge