Skip to content

Update top-bar on new project/group pages to be fixed to top of viewport

Scott de Jonge requested to merge 415851-update-glbreadcrumb-on-create-pages-to-be-full-width-and-sticky into master

What does this MR do and why?

Update top-bar on new project/group pages to be fixed to top of viewport

  • Update <new-namespace-page> top-bar with .top-bar-fixed and .container-fluid classes
  • Separate hiding top-bar with @hide_top_bar and hiding top-bar padding top on .content-wrapper with @hide_top_bar_padding
  • Update terms.html.haml to hide padding with @hide_top_bar_padding

Screenshots or screen recordings

New group

Before After
new-group-before new-group-after

New project

Before After
new-project-before new-project-after

Terms

Before After
127.0.0.1_3000_-users_terms_redirect__2F__2 127.0.0.1_3000_-users_terms_redirect__2F__2

How to set up and validate locally

  1. Review /groups/new with new and old navigation
  2. Review /projects/new with new and old navigation
  3. Review terms view

To view terms page:

  1. Login as an admin (root user in GDK).
  2. Navigate to /admin/application_settings/general
  3. In the Terms of Service and Privacy Policy panel:
    1. Check the All users must accept the Terms of Service and Privacy Policy to access GitLab checkbox
    2. Enter some text in the text area
    3. Save the form
  4. Navigate to /admin/users and choose a user.
  5. Click Impersonate in the upper right corner.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #415851 (closed)

Edited by Scott de Jonge

Merge request reports