Fix focus on vulnerability details comment
What does this MR do and why?
Related to #421928 (closed)
On safari, it's not possible to add a comment in the discussions on the vulnerability details page. A button cannot be focused on safari and hence the @focus event does not work. This is fixed by using a textarea instead.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
| Before | After |
|---|---|
 |
 |
 |
 |
How to set up and validate locally
On safari, but also Chrome or firefox.
Prerequisites
- You'll need an EE license
- You'll need to have runners enabled (See $2408961 for setting up a runner)
- Import https://gitlab.com/gitlab-examples/security/security-reports
- Run a pipeline on master
Validate
- Go to the details page of a vulnerability that is not in Needs triage state (i.e. it's had a state change and will have a system note to comment on)
- Validate that focusing on the "Add a comment" placeholder by tabbing opens up the editor to add a comment
- Validate that clicking on the same placeholder also opens the editor
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.