Audit delivery of confirmation emails
What does this MR do and why?
This MR adds audit events when an email confirmation is requested by the Emails::Confirm service or an email was changed on the User model.
This will allow us to track when users request email confirmations and when they change their email addresses.
- Implements part of Instance Level Audit Event Enhancement for User... (#377625) • Unassigned • Backlog
How to set up and validate locally
- Setup a streaming destination for audit events (Admin area -> Monitoring -> Audit Events -> Streams)
- Change the signed in users's email address.
- Add an additional email address for that user
- Verify that an audit event is streamed when adding an email address
- Verify that an audit event is streamed when changing your email address on your profile
MR acceptance checklist
-
I have evaluated the MR acceptance checklist for this MR.
This description was generated for revision 4aa7ebbf using AI ...and then manually revised.
Merge request reports
Activity
added featureaddition groupcompliance sectionsec typefeature workflowin review labels
assigned to @sam.figueroa
added devopsgovern label
changed milestone to %16.3
- A deleted user
added backend documentation labels
- Resolved by Rajendra Kadam
1 Message This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. Documentation review
The following files require a review from a technical writer:
-
doc/administration/audit_event_streaming/audit_event_types.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Aakriti Gupta (
@aakriti.gupta
) (UTC+5.5, 3.5 hours ahead of@sam.figueroa
)Matt Kasa (
@mattkasa
) (UTC-7, 9 hours behind@sam.figueroa
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger -
@sam.figueroa Some end-to-end (E2E) tests should run based on the stage label.
Please start the
trigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure tests in thefollow-up-e2e:package-and-test-ee
pipeline pass before this MR is merged. (E2E tests are computationally intensive and don't run automatically for every push/rebase, so we ask you to run this job manually at least once.)To run all E2E tests, apply the pipeline:run-all-e2e label and run a new pipeline.
E2E test jobs are allowed to fail due to flakiness. See current failures at the latest pipeline triage issue.
Once done, apply the
emoji on this comment.For any questions or help, reach out on the internal #quality Slack channel.
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 1b9b6863expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Manage | 12 | 0 | 1 | 1 | 13 | ❗ | | Govern | 36 | 0 | 0 | 0 | 36 | ✅ | | Plan | 47 | 0 | 0 | 0 | 47 | ✅ | | Data Stores | 20 | 0 | 0 | 0 | 20 | ✅ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | | Create | 38 | 0 | 0 | 2 | 38 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 161 | 0 | 1 | 3 | 162 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+
mentioned in issue #377625
- Resolved by Jay Montal
requested review from @huzaifaiftikhar1
- Resolved by SAM FIGUEROA
- Resolved by SAM FIGUEROA
- Resolved by Huzaifa Iftikhar
changed milestone to %16.4
added missed:16.3 label
requested review from @rkadam3 and removed review request for @huzaifaiftikhar1
@huzaifaiftikhar1
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by Rajendra Kadam
- Resolved by SAM FIGUEROA
- Resolved by Rajendra Kadam
Just one suggestion regarding a typo.
Rest looks good.
added 78 commits
-
c12cc290...21b83362 - 76 commits from branch
master
- 3b0c6c63 - Audit delivery of confirmation emails
- 1b9b6863 - Fix failing specs
-
c12cc290...21b83362 - 76 commits from branch
enabled an automatic merge when the pipeline for f089bca5 succeeds
mentioned in commit 0dc676cf
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2437 (merged)