Skip to content

GitLab for Jira - Allow admins to view and link all groups

Justin Ho Tuan Duong requested to merge 411768-gitlab-admins-that-aren-t-explicit-owners-maintainers-cannot-link-namespaces-in-the-jira-app into master

What does this MR do and why?

A previous MR !126110 (merged) attempted to fix this issue but the solution but did not consider all scenarios and was reverted.

In the GitLab for Jira app, admins should be able to view and link all groups on the instance, even when they are not direct maintainers of that group.

This change moves the logic to set min_access_level from the backend helper to frontend to allow omitting this param when user is an admin.

Changelog: changed

Screenshots or screen recordings

📝 Description: Observe that the After (for admins) screenshot includes "Justin secret group" which the admin is not a direct maintainer of but is a group on the instance and they have access to.

Before After (for admins) After (for maintainers)
GitLab_for_Jira_-_change_group_param_before GitLab_for_Jira_admin_access GitLab_for_Jira_maintainer_access

How to set up and validate locally

  1. Setup the GitLab for Jira app with this guide: https://docs.gitlab.com/ee/development/integrations/jira_connect.html#simple-setup.
  2. Select GitLab.com (though we will be using GDK). Then login and click Link groups.
  3. (In a new tab, if not already available) Create a new user and a group under that user (admin must not be a member).
  4. Refresh the GitLab for Jira app and click Link groups. See that the newly created group is now visible.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #411768 (closed)

Edited by Justin Ho Tuan Duong

Merge request reports