Skip to content

GitLab for Jira - Show all groups that admin have access to

Justin Ho Tuan Duong requested to merge 411768-gitlab-admins-that-aren-t-explicit-owners-maintainers-cannot-link-namespaces-in-the-jira-app into master

What does this MR do and why?

Change request to groups API to use all_available param. Instead of using "min_access_level", we now use "all_available" to allow admins to link groups even if they are not direct maintainers of the group.

Changelog: changed

Screenshots or screen recordings

Note: Changed copy and more groups are shown (as we now include groups that the user is not a direct maintainer of). In the screenshot, I am using "Justin secret group" that admin is not a member of but still has access to (as they are an administrator).

Before After
GitLab_for_Jira_-_change_group_param_before GitLab_for_Jira_-_change_group_param_after

How to set up and validate locally

  1. Setup the GitLab for Jira app with this guide: https://docs.gitlab.com/ee/development/integrations/jira_connect.html#simple-setup.
  2. Select GitLab.com (though we will be using GDK). Then login and click Link groups.
  3. (In a new tab, ff not already available) Create a new user and a group under that user (admin must not be a member).
  4. Refresh the GitLab for Jira app and click Link groups. See that the newly created group is now visible.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #411768 (closed)

Edited by Justin Ho Tuan Duong

Merge request reports