Adding decompress_archive_file_timeout to application settings
What does this MR do and why?
Currently the hardcoded timeout of 210seconds for decompressing archived files is too short for some customers. If we were to move this to application settings, self-managed users can set their own timeouts depending on how long they want to wait.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
![]() |
![]() |
How to set up and validate locally
- Ensure import/export still works.
- Timeout is changeable, by changing the timeout limit in the UI and then going into rails console to check
Gitlab::CurrentSettings.current_application_settings.decompress_archive_file_timeout
or the new database columndecompress_archive_file_timeout
should reflect the new changed timeout value
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #421432 (closed)
Merge request reports
Activity
changed milestone to %16.4
assigned to @mfanGitLab
- Resolved by Max Fan
3 Warnings b1345422: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. 7f39c2ed: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. Please add a merge request subtype to this merge request. 2 Messages This merge request adds or changes files that require a review from the Database team. This merge request adds or changes documentation files. A review from the Technical Writing team before you merge is recommended. Reviews can happen after you merge. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
The following files require a review from the Database team:
db/migrate/20230814181359_add_decompress_archive_file_timeout_to_application_setting.rb
db/schema_migrations/20230814181359
db/structure.sql
Documentation review
The following files require a review from a technical writer:
-
doc/administration/settings/account_and_limit_settings.md
(Link to current live version) -
doc/api/settings.md
(Link to current live version)
The review does not need to block merging this merge request. See the:
-
Metadata for the
*.md
files that you've changed. The first few lines of each*.md
file identify the stage and group most closely associated with your docs change. - The Technical Writer assigned for that stage and group.
- Documentation workflows for information on when to assign a merge request for review.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Piotr Skorupa (
@pskorupa
) (UTC+2)Andy Soiron (
@Andysoiron
) (UTC+2)database Charlie Ablett (
@cablett
) (UTC+12)Andy Soiron (
@Andysoiron
) (UTC+2)frontend Rajan Mistry (
@ramistry
) (UTC+5.5)Himanshu Kapoor (
@himkp
) (UTC+7)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger @mfanGitLab Some end-to-end (E2E) tests have been selected based on the stage label on this MR.Please start the
trigger-omnibus-and-follow-up-e2e
job in theqa
stage and ensure the tests infollow-up-e2e:package-and-test-ee
pipeline are passing before this MR is merged. (The E2E test pipeline is computationally intensive and we cannot afford running it automatically for all pushes/rebases. Therefore, this job must be triggered manually after significant changes at least once.)If you would like to run all E2E tests, please apply the pipeline:run-all-e2e label and trigger a new pipeline. This will run all tests in
e2e:package-and-test
pipeline.The E2E test jobs are allowed to fail due to flakiness. For the list of known failures please refer to the latest pipeline triage issue.
Once done, please apply the
emoji on this comment.For any questions or help in reviewing the E2E test results, please reach out on the internal #quality Slack channel.
added 173 commits
-
d828f0e2...6fed0664 - 172 commits from branch
master
- 8918f20e - Adding decompress_archive_file_timeout to application settings
-
d828f0e2...6fed0664 - 172 commits from branch
- A deleted user
added database databasereview pending labels
- A deleted user
added Data WarehouseImpact Check label
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for af24c83fexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Manage | 13 | 0 | 1 | 1 | 14 | ❗ | | Govern | 34 | 0 | 0 | 0 | 34 | ✅ | | Create | 36 | 2 | 0 | 2 | 38 | ❌ | | Plan | 47 | 0 | 0 | 0 | 47 | ✅ | | Data Stores | 20 | 0 | 0 | 0 | 20 | ✅ | | Verify | 8 | 0 | 0 | 0 | 8 | ✅ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 158 | 2 | 1 | 3 | 161 | ❌ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 586b0b88expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 151 | 0 | 35 | 12 | 186 | ❗ | | Manage | 158 | 1 | 12 | 27 | 171 | ❌ | | Configure | 1 | 0 | 0 | 0 | 1 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Govern | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 334 | 1 | 51 | 39 | 386 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
- A deleted user
added frontend label
Database migrations (on the main database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20230814181359 - AddDecompressArchiveFileTimeoutToApplicationSetting Regular 2.2 s +0.00 B Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 4 0.1 seconds - 1 second 0 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20230814181359 - AddDecompressArchiveFileTimeoutToApplicationSetting
- Type: Regular
- Duration: 2.2 s
- Database size change: +0.00 B
Calls Total Time Max Time Mean Time Rows Query 1 18.7 ms 18.7 ms 18.7 ms 0 ALTER TABLE "application_settings" ADD "decompress_archive_file_timeout" integer DEFAULT 210 NOT NULL
2 0.0 ms 0.0 ms 0.0 ms 2 SELECT pg_backend_pid()
1 0.0 ms 0.0 ms 0.0 ms 1 SELECT $1::regtype::oid
Histogram for AddDecompressArchiveFileTimeoutToApplicationSetting
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 4 0.1 seconds - 1 second 0 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Other information
No other migrations pending on GitLab.com
Clone details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-2222216-10922352-main
2023-08-16T20:06:50Z 2023-08-16T16:17:51Z 2023-08-17 08:12:32 +0000 database-testing-2222216-10922352-ci
2023-08-16T20:06:50Z 2023-08-12T15:50:05Z 2023-08-17 08:12:32 +0000 Database migrations (on the ci database)
1 Warnings 20230814181359 - AddDecompressArchiveFileTimeoutToApplicationSetting had a query that
exceeded timing guidelines. Run time should not exceed 100ms, but it was 102.52ms. Please consider
possible options to improve the query performance.ALTER TABLE "application_settings" ADD
"decompress_archive_file_timeout" integer DEFAULT 210 NOT NULLMigrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20230814181359 - AddDecompressArchiveFileTimeoutToApplicationSetting Regular 2.7 s +0.00 B Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 3 0.1 seconds - 1 second 1 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20230814181359 - AddDecompressArchiveFileTimeoutToApplicationSetting- Type: Regular
- Duration: 2.7 s
- Database size change: +0.00 B
Calls Total Time Max Time Mean Time Rows Query 1 102.5 ms 102.5 ms 102.5 ms 0 ALTER TABLE "application_settings" ADD "decompress_archive_file_timeout" integer DEFAULT 210 NOT NULL
1 0.0 ms 0.0 ms 0.0 ms 1 SELECT $1::regtype::oid
2 0.0 ms 0.0 ms 0.0 ms 2 SELECT pg_backend_pid()
Histogram for AddDecompressArchiveFileTimeoutToApplicationSetting
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 3 0.1 seconds - 1 second 1 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Other information
Other migrations pending on GitLab.com
Migration Type Total runtime Result DB size change 20230728171609 - AddCiJobAnnotationsPlanLimits Regular 3.0 s +0.00 B 20230803125434 - AddHasMergeRequestOnVulnerabilityReadsTrigger Regular 2.7 s +0.00 B 20230804064817 - BackfillGoogleCloudLoggingName Regular 2.8 s +0.00 B 20230804065052 - AddNotNullToGcpConfigName Regular 2.5 s +0.00 B 20230807101745 - AddActiveToAuditEventsStreamingHeaders Regular 2.6 s +8.00 KiB [note] 20230807105131 - AddActiveToInstanceAuditEventsStreamingHeaders Regular 2.6 s +0.00 B 20230808140338 - AddFluxResourceColumnToEnvironments Regular 3.4 s +0.00 B 20230809165212 - AddPathPrefixAndBuildRefToPagesDeployments Regular 2.7 s +0.00 B 20230809165213 - AddIndexToPathPrefixAndBuildRefToPagesDeployments Regular 4.2 s +8.00 KiB [note] 20230809192256 - AddFileSizeLimitToPlanLimits Regular 2.6 s +0.00 B 20230810132301 - AddHasRemediationsToVulnerabilityReads Regular 2.6 s +0.00 B 20230814055259 - AddPipelineIdAndExportTypeToDependencyListExports Regular 2.6 s +0.00 B 20230814055310 - AddIndexPipelineIdToDependencyListExports Regular 3.0 s +8.00 KiB [note] 20230701053315 - EnsureAgainBackfillForCiPipelineVariablesPipelineIdIsFinished Post deploy 2.7 s +0.00 B 20230712052619 - DropIndexDeploymentsOnProjectIdAndStatus Post deploy 3.6 s +0.00 B 20230712054057 - DropIndexDeploymentsOnProjectIdSha Post deploy 3.5 s +0.00 B 20230712055956 - DropIndexDeploymentsOnEnvironmentIdAndIidAndProjectId Post deploy 3.6 s +0.00 B 20230726024322 - AddNotValidForeignKeyForCiPipelineVariablesPipelineId Post deploy 3.6 s +8.00 KiB [note] 20230727102936 - DropPreparedAtIndex Post deploy 4.2 s +8.00 KiB [note] 20230727103144 - AddPreparedAtCreatedAtIndex Post deploy 4.0 s +0.00 B 20230727132342 - PrepareIndexOnVulnerabilityOccurrencesUuidAsync Post deploy 3.0 s +0.00 B 20230728122928 - PrepareIndexOnVulnerabilityOccurrencesUuidIncludingVulnerabilityIdAsync Post deploy 2.7 s +0.00 B 20230804053643 - AddTicketWorkItemType Post deploy 2.6 s +0.00 B 20230804121704 - RemoveNamespacesUserDetailsEnterpriseGroupIdFk Post deploy 3.0 s +0.00 B 20230804121705 - RemoveNamespacesUserDetailsProvisionedByGroupIdFk Post deploy 3.0 s +0.00 B 20230809090349 - EnsureIdUniquenessForPCiBuildsV2 Post deploy 3.1 s +0.00 B 20230809133249 - IndexSbomOccurrencesOnProjectIdComponentIdAndInputFilePath Post deploy 3.2 s +8.00 KiB [note] 20230810122746 - EnsureSnippetUserMentionsBigintBackfillIsFinishedForSelfHosts Post deploy 2.5 s +0.00 B 20230810123044 - SwapSnippetUserMentionsNoteIdToBigintForSelfHosts Post deploy 2.5 s +0.00 B 20230811103654 - EnsureVumBigintBackfillIsFinishedForSelfHosts Post deploy 2.4 s +0.00 B 20230811103941 - SwapVulnerabilityUserMentionsNoteIdToBigintForSelfHosts Post deploy 2.5 s +0.00 B Clone details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-2222216-10922352-main
2023-08-16T20:06:50Z 2023-08-16T16:17:51Z 2023-08-17 08:12:32 +0000 database-testing-2222216-10922352-ci
2023-08-16T20:06:50Z 2023-08-12T15:50:05Z 2023-08-17 08:12:32 +0000
Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic
- A deleted user
added database-testing-automation label
added 1 commit
- 586b0b88 - Adding decompress_archive_file_timeout to application settings
changed milestone to %16.3
changed milestone to %16.4
added 248 commits
-
586b0b88...476da674 - 247 commits from branch
master
- 49b84fdd - Adding decompress_archive_file_timeout to application settings
-
586b0b88...476da674 - 247 commits from branch
- Resolved by Chad Woolley
Hi @carlad-gl , can you help do the initial backend review as you have some domain knowledge? I can re-assign if you're at capacity
- Resolved by Chad Woolley
@mfluharty can you help with the frontend review?
- Resolved by Chad Woolley
@eread can you help with the Technical Writing review?
- Resolved by Chad Woolley
@mhamda can you help with the database review? There's some flaky specs that have been failing in this pipeline. Wondering if you've seen them around?
An error occurred in an `after(:context)` hook. Failure/Error: connection.public_send(...) ActiveRecord::QueryCanceled: PG::QueryCanceled: ERROR: canceling statement due to statement timeout # ./lib/gitlab/database/load_balancing/connection_proxy.rb:127:in `public_send' # ./lib/gitlab/database/load_balancing/connection_proxy.rb:127:in `block in write_using_load_balancer' # ./lib/gitlab/database/load_balancing/load_balancer.rb:133:in `block in read_write' # ./lib/gitlab/database/load_balancing/load_balancer.rb:204:in `retry_with_backoff' # ./lib/gitlab/database/load_balancing/load_balancer.rb:122:in `read_write' # ./lib/gitlab/database/load_balancing/connection_proxy.rb:126:in `write_using_load_balancer' # ./lib/gitlab/database/load_balancing/connection_proxy.rb:96:in `method_missing' # ./lib/gitlab/database/load_balancing/connection_proxy.rb:127:in `public_send' # ./lib/gitlab/database/load_balancing/connection_proxy.rb:127:in `block in write_using_load_balancer' # ./lib/gitlab/database/load_balancing/load_balancer.rb:133:in `block in read_write' # ./lib/gitlab/database/load_balancing/load_balancer.rb:204:in `retry_with_backoff' # ./lib/gitlab/database/load_balancing/load_balancer.rb:122:in `read_write' # ./lib/gitlab/database/load_balancing/connection_proxy.rb:126:in `write_using_load_balancer' # ./lib/gitlab/database/load_balancing/connection_proxy.rb:96:in `method_missing' # ./spec/support/db_cleaner.rb:11:in `delete_from_all_tables!' # ./spec/rake_helper.rb:15:in `block (2 levels) in <top (required)>' # ------------------ # --- Caused by: --- # PG::QueryCanceled: # ERROR: canceling statement due to statement timeout # ./lib/gitlab/database/load_balancing/connection_proxy.rb:127:in `public_send'
requested review from @carlad-gl, @mfluharty, @eread, and @mhamda
- Resolved by Chad Woolley
added Technical Writing UI text docsfeature labels
removed review request for @eread
removed review request for @mhamda
requested review from @l.rosa
@mhamda
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
added databasereviewed label and removed databasereview pending label
added Data WarehouseNot Impacted label and removed Data WarehouseImpact Check label
requested review from @jivanvl and removed review request for @mfluharty
removed review request for @jivanvl
requested review from @cwoolley-gitlab and removed review request for @carlad-gl
- Resolved by Leonardo da Rosa
@mfanGitLab, great work! I left only a small comment for you to take a look at
added 421 commits
-
49b84fdd...ed8e4d9a - 418 commits from branch
master
- adb3fd56 - Adding decompress_archive_file_timeout to application settings
- 0b573c5b - Adding disable_dd_transactions
- cf05808e - Running regenerate-schema
Toggle commit list-
49b84fdd...ed8e4d9a - 418 commits from branch
11930 11930 sentry_clientside_traces_sample_rate double precision DEFAULT 0.0 NOT NULL, 11931 11931 protected_paths_for_get_request text[] DEFAULT '{}'::text[] NOT NULL, 11932 11932 max_decompressed_archive_size integer DEFAULT 25600 NOT NULL, 11933 ci_max_total_yaml_size_bytes integer DEFAULT 157286400 NOT NULL, 11934 11933 prometheus_alert_db_indicators_settings jsonb, 11934 ci_max_total_yaml_size_bytes integer DEFAULT 157286400 NOT NULL, Good callout! This was actually changed because I ran
./scripts/regenerate-schema
.I don't think this was in the right spot in the beginning? Reasoning: New columns are added at the bottom: https://docs.gitlab.com/ee/development/migration_style_guide.html#schema-changes
prometheus_alert_db_indicators_settings jsonb,
was renamed in migrate/20230808123101_rename_application_settings_database_apdex_settings.rbci_max_total_yaml_size_bytes integer DEFAULT 157286400 NOT NULL,
was added in migrate/20230808135706_add_max_yaml_size_to_application_settings.rbSo ci_max_total... should be below prometheus_alert on structure.sql? Can you help confirm @l.rosa
and re-approve if it looks good?Edited by Max Fan@mfanGitLab after rebasing with master and regenerating the schema with
bin/rails db:reset
, this is the version of the schema I got:max_decompressed_archive_size integer DEFAULT 25600 NOT NULL, -prometheus_alert_db_indicators_settings jsonb, ci_max_total_yaml_size_bytes integer DEFAULT 157286400 NOT NULL, +prometheus_alert_db_indicators_settings jsonb, decompress_archive_file_timeout integer DEFAULT 210 NOT NULL
Thank you for double checking! @l.rosa
. Rebasing off master moved it! I'm a bit confused though, do you know why theci_max_total_yaml
is beforeprometheus
even though the migration happens after?CC: @cwoolley-gitlab as the approval was lost
@mfanGitLab From Postgres docs:
Postgres currently defines column order based on the attnum column of the pg_attribute table. The only way to change column order is either by recreating the table, or by adding columns and rotating data until you reach the desired layout.
Let's take a look at the table order in the DB, in the master branch:
SELECT table_information.relname AS table_name, col_information.attname AS column_name, col_information.attnum AS column_order FROM pg_attribute AS col_information JOIN pg_class AS table_information ON col_information.attrelid = table_information.oid JOIN pg_namespace AS schema_information ON table_information.relnamespace = schema_information.oid WHERE table_information.relkind IN ('r', 'p') AND schema_information.nspname IN ('public') AND table_information.relname = 'application_settings' AND col_information.attname IN ('max_decompressed_archive_size', 'ci_max_total_yaml_size_bytes', 'prometheus_alert_db_indicators_settings', 'decompress_archive_file_timeout') ORDER BY col_information.attnum;
After resetting the
db
, I'm getting the following column order:table_name column_name column_order application_settings max_decompressed_archive_size 519 application_settings ci_max_total_yaml_size_bytes 520 application_settings prometheus_alert_db_indicators_settings 521 Then, after switching to this branch and performing an
bin/rails db:migrate
, I'm getting:table_name column_name column_order application_settings max_decompressed_archive_size 519 application_settings ci_max_total_yaml_size_bytes 520 application_settings prometheus_alert_db_indicators_settings 521 application_settings decompress_archive_file_timeout 522 In the development cycle, column order is more based on the order that migrations reach master (and change the schema), rather than migration order itself. In this case, the schema was changed before. If we recreate the
DB
using migration order, then, the column order will be different:bin/rails db:drop db:create db:migrate
table_name column_name column_order application_settings max_decompressed_archive_size 546 application_settings prometheus_alert_db_indicators_settings 548 application_settings ci_max_total_yaml_size_bytes 549 application_settings decompress_archive_file_timeout 550 I believe something happened in this MR, as the column order doesn't seem right. My guess is:
- MR was opened some time ago;
-
20230808123136_cleanup_application_settings_database_apdex_settings_rename.rb
was created; -
20230808135706_add_max_yaml_size_to_application_settings.rb
was created, localdb
was migrated; -
20230808123136_cleanup_application_settings_database_apdex_settings_rename.rb
was merged to master; -
MR was rebased, but, at the local
db
,20230808135706
was applied first than20230808123136
; - When the dump was created, the column order was swapped;
So, it seems that
ci_max_total_yaml_size_bytes
was not placed in the correct order in the schema. I'll tag the MR author to take a look/cc @Kasia_Misirli
CC @l.rosa
- Resolved by Chad Woolley
@mfanGitLab This looks good. I left a couple of non-blocking suggestions for cleanup, but I'll go ahead and approve it.
I'll wait to merge to let you address those suggestions if you want. Ping me again when it's ready for merge.
added 383 commits
-
cf05808e...831cad01 - 379 commits from branch
master
- eae6ac15 - Adding decompress_archive_file_timeout to application settings
- 7f39c2ed - Adding disable_dd_transactions
- b1345422 - Running regenerate-schema
- af24c83f - Moving prometheus_alert_db_indicators_settings down one
Toggle commit list-
cf05808e...831cad01 - 379 commits from branch
mentioned in issue #422757 (closed)
- Resolved by Chad Woolley
@mhamda @carlad-gl This needs a re-approval due to rebase, then I can merge.
requested review from @mhamda and @carlad-gl and removed review request for @cwoolley-gitlab and @l.rosa
Thanks, @mfanGitLab, database LGTM!
@cwoolley-gitlab, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
- Resolved by Max Fan
Hello @mfanGitLab
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
mentioned in commit 81d30c9d
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
@mfanGitLab I'm currently running into a small issue in my GDK on the
master
branch. When runningscripts/regenerate-schema
, the command fails withNoMethodError: undefined method `decompress_archive_file_timeout' for #<ApplicationSetting id: 1 [...]`.
It is very likely that my GDK is borked for some other reason as I haven't updated it in a month. I thought I would drop a note here anyways before I resume my investigation in case this is in fact related to this MR.
Edited by Paul Gascou-Vaillancourt@pgascouvaillancourt @mfanGitLab I just ran into this as well. I think the problem is that some application setting is getting loaded in order to perform the migration, so the validation breaks any migration that runs prior to the column has been added.
@hfyngvason @pgascouvaillancourt do you get the same error if you do the
db:migrate
first and then do theregenerate-schema
?@mfanGitLab Good theory. It runs fine for all subsequent invocations, so maybe that would have helped. Possibly
RAILS_ENV=test bin/rails db:migrate
might be required, given thatscripts/regenerate-schema
uses the test db. But I haven't attempted any more elaborate reproduction.I think it is this line of code, getting invoked as part of
rake db:reset
.Yeah I think that's right. It looks like you need to have the migrations up-to-date first before you can try to
regenerate-schema
. The script only throws if ApplicationSettings are touched (which this MR does) so it's not very noticeable.I think there's a bunch of edge case
regenerate-schema
doesn't consider, that's why it was removed from ci !31101 (merged) and hasn't been touched in a couple of years.
- Resolved by Evan Read
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
mentioned in merge request !130229 (merged)
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2437 (merged)
removed review request for @mhamda
added sectioncore platform label and removed sectiondev label