Skip to content

Do not require PAT for 'access_code_suggestions' policy

Aleksei Lipniagov requested to merge 421565-fix-code_suggestions_enabled_by_instance-policy into master

What does this MR do and why?

Code Suggestions PAT field is no longer required on SM: !127987 (merged)

This needs to be reflected in a policy: https://gitlab.com/gitlab-org/gitlab/-/blob/master/ee/app/policies/ee/global_policy.rb?ref_type=heads#L67

How to set up and validate locally

  1. Make sure you have a license on your GDK
  2. Check the "Enable Code Suggestions for this instance" toggle. You could refer to !127987 (merged) for screenshots. You could double check in rails console: ::Gitlab::CurrentSettings.reload.instance_level_code_suggestions_enabled (should be true)
  3. Keep an empty token field
  4. Proceed with the flow in !125563 (merged)

On this branch: the flow will work as described
On master: the flow will work only with the non-empty "Personal Access Token" field (you could put any value into that, e.g. "1")

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #421565 (closed)

Edited by Aleksei Lipniagov

Merge request reports