Skip to content

Add updated hook to packages shared title area component

Rahul Chanila requested to merge 413395-packages-title-area-updated-hook into master

What does this MR do and why?

Why

Cleanup title area shared registry component (!128055 - merged) has caused ~bug where container registry images count are not displayed.

What

Add back updated hook which recalculates slots in the title-area component.

This reverts behaviour & tests removed in Cleanup title area shared registry component (!128055 - merged).

We could add the v-if to the element instead of the template but that causes Fix alignment of Expiration policy text when th... (#361319 - closed) so reverting behaviour instead.

Screenshots or screen recordings

Page Before After
Group Screenshot_2023-08-10_at_4.06.04_pm Screenshot_2023-08-10_at_3.51.41_pm
Project Screenshot_2023-08-10_at_4.05.50_pm Screenshot_2023-08-10_at_3.51.32_pm

How to set up and validate locally

Images list

  1. Setup & enable Container Registry https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/doc/howto/registry.md
  2. Follow steps in https://gitlab.com/gitlab-org/ci-cd/package-stage/package/-/wikis/Packages-Tips-&-Tricks#how-to-add-images-with-tags-quickly-to-the-registry
  3. Run the following in the terminal
    $ ./publish.sh <project-path> 2 10 127.0.0.1:5000 # creates 10 images with 2 tags each
  4. Visit the container registry list page for the project <group-name>/<project-name>/container_registry and confirm 10 Image repositories is shown.
  5. Visit the container registry list page for the group groups/<group-name>/-/container_registries and confirm 10 Image repositories count is shown.

Tags list

  1. After following previous instructions, visit the container registry list page for the project
  2. Clicking one of the images should take you the tags list(details) page

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #413395 (closed)

Edited by Rahul Chanila

Merge request reports