Fix broken dependency list for invalid Container Scanning pkg mgr type
What does this MR do and why?
Backport !128385 (merged) into 16.2.
Fix broken dependency list for invalid Container Scanning pkg mgr type
See Fix broken dependency list for invalid Containe... (!128385 - merged)
What are the relevant issue numbers?
- Dependency list page throws error if Container ... (#420664 - closed)
- [License/Dependeny Scanning] Error fetching the... (#421027 - closed)
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.3
assigned to @thiagocsf
requested review from @thiagocsf
requested review from @adamcohen and removed review request for @thiagocsf
mentioned in issue #421027 (closed)
1 Warning The e2e:package-and-test-ee
job needs to succeed or have approval from a Software Engineer in Test.
Read the "QA e2e:package-and-test-ee" section for more details.1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend David Dieulivol (
@ddieulivol
) (UTC+2, 8 hours behind@thiagocsf
)Nicolas Dular (
@nicolasdular
) (UTC+2, 8 hours behind@thiagocsf
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
QA
e2e:package-and-test-ee
@thiagocsf, the
package-and-test
job must complete before merging this merge request.*If there are failures on the
package-and-test
pipeline, ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the#quality
Slack channel.If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-package-and-test:
test report for 92fe2de8expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Secure | 6 | 0 | 27 | 0 | 33 | ✅ | | Create | 136 | 0 | 16 | 7 | 152 | ❗ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 142 | 0 | 43 | 7 | 185 | ❗ | +--------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test-old-nav:
test report for 92fe2de8expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Secure | 6 | 0 | 27 | 0 | 33 | ✅ | | Create | 135 | 1 | 16 | 7 | 152 | ❌ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 141 | 1 | 43 | 7 | 185 | ❌ | +--------+--------+--------+---------+-------+-------+--------+
- Resolved by Thiago Figueiró
@thiagocsf Thee2e:package-and-test-ee
job has failed.-
e2e:package-and-test-ee
pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/961415476
e2e:package-and-test-ee
pipeline is allowed to fail due its flakiness. Failures should be investigated to guarantee this backport complies with the Quality standards.Ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the
#quality
Slack channel. -
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
- Resolved by Kerri Miller
Thanks for opening this MR @thiagocsf, LGTM!
@kerrizor can you please provide a maintainer review on this since you reviewed the original MR? Thanks!
requested review from @kerrizor
- Resolved by Kerri Miller
@adamcohen
, thanks for approving this merge request.This is the first time the merge request is approved. Please ensure the
e2e:package-and-test-ee
job has succeeded. If there is a failure, a Software Engineer in Test (SET) needs to confirm the failures are unrelated to the merge request. If there's no SET assigned to this team, ask for assistance on the#quality
Slack channel.
enabled an automatic merge when the pipeline for d9100479 succeeds