Skip to content

Show reviewer roulette when there's only codeowners approvals

What does this MR do and why?

Now that we rely more and more on CODEOWNERS for the reviewer roulette, it can happen that we don't have any "changes" detected from the roulette helper (which is based on paths of changed files that match regexes), but we'd have codeowner approvals required.

This MR makes sure we show the reviewer roulette table in that case.

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After
Screenshot_2023-08-08_at_10.11.57 Screenshot_2023-08-09_at_18.59.18

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #421274 (closed)

Edited by Rémy Coutable

Merge request reports