Adjust Danger logic for stable branches
What does this MR do and why?
Backport of !128409 (merged) so we can have the updated Danger rule take effect in the 16-1-stable-ee branch. I intend to backport to all branches in the next security release since they will be the most targeted branches for backports.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch. -
The original MR has been deployed to GitLab.com (not applicable for documentation or spec changes). -
This MR has a severity label assigned (if applicable). -
This MR has been approved by a maintainer (only one approval is required). -
Ensure the e2e:package-and-test-ee
job has either succeeded or been approved by a Software Engineer in Test.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releases
Slack channel (internal only).
Merge request reports
Activity
added groupdelivery teamOrchestration typebug labels
assigned to @sabrams
added devopsplatforms sectionplatforms labels
mentioned in issue gitlab-com/gl-infra/delivery#19492 (closed)
- A deleted user
added backend label
4 Warnings This merge request does not refer to an existing milestone. Backporting to older releases requires an exception request process The e2e:package-and-test-ee
job needs to succeed or have approval from a Software Engineer in Test.
Read the "QA e2e:package-and-test-ee" section for more details.Please add a merge request subtype to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Hinam Mehra (
@hmehra
) (UTC+10, 16 hours ahead of@sabrams
)Roy Zwambag (
@rzwambag
) (UTC+2, 8 hours ahead of@sabrams
)maintenanceworkflow / maintenancepipelines for CI, Danger Javiera Tapia (
@jtapiab
) (UTC-4, 2 hours ahead of@sabrams
)David Dieulivol (
@ddieulivol
) (UTC+2, 8 hours ahead of@sabrams
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
QA
e2e:package-and-test-ee
@sabrams, the
package-and-test
job must complete before merging this merge request.*If there are failures on the
package-and-test
pipeline, ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the#quality
Slack channel.If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerAllure report
allure-report-publisher
generated test report!e2e-package-and-test:
test report for 6fabeba3expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Systems | 13 | 0 | 0 | 0 | 13 | ✅ | | Plan | 9 | 0 | 1 | 0 | 10 | ✅ | | Manage | 53 | 6 | 2 | 17 | 61 | ❌ | | Create | 156 | 0 | 20 | 12 | 176 | ❗ | | Package | 25 | 0 | 0 | 0 | 25 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 5 | 0 | 0 | 0 | 5 | ✅ | | Analytics | 1 | 0 | 0 | 0 | 1 | ✅ | | Configure | 1 | 0 | 0 | 0 | 1 | ✅ | | Monitor | 12 | 0 | 1 | 0 | 13 | ✅ | | Data Stores | 15 | 0 | 3 | 0 | 18 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 294 | 6 | 30 | 29 | 330 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
- Resolved by Steve Abrams
@sabrams Thee2e:package-and-test-ee
job has failed.-
e2e:package-and-test-ee
pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/959799067
e2e:package-and-test-ee
pipeline is allowed to fail due its flakiness. Failures should be investigated to guarantee this backport complies with the Quality standards.Ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the
#quality
Slack channel. -
- Resolved by Reuben Pereira
@ddieulivol, would you please review this backport of !128409 (merged) to 16-1 which you previously reviewed?
Setting label(s) Category:Delivery based on groupdelivery.
added Category:Delivery label
requested review from @ddieulivol
mentioned in merge request !128766 (merged)
- Resolved by Steve Abrams
@ddieulivol
, thanks for approving this merge request.This is the first time the merge request is approved. Please ensure the
e2e:package-and-test-ee
job has succeeded. If there is a failure, a Software Engineer in Test (SET) needs to confirm the failures are unrelated to the merge request. If there's no SET assigned to this team, ask for assistance on the#quality
Slack channel.
requested review from @rpereira2
enabled an automatic merge when the pipeline for d8173886 succeeds
- Resolved by Steve Abrams
@sabrams Thee2e:package-and-test-ee
job has failed.-
e2e:package-and-test-ee
pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/967207201
e2e:package-and-test-ee
pipeline is allowed to fail due its flakiness. Failures should be investigated to guarantee this backport complies with the Quality standards.Ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the
#quality
Slack channel. -
mentioned in commit 1e95bbbc