Remove usage of dismissMultipleVulnerabilities feature flag in FE code
What does this MR do and why?
This change removes the usage of the dismissMultipleVulnerabilities feature flag from the frontend code.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.3
added frontend groupthreat insights maintenancerelease labels
assigned to @mokhax
added typemaintenance label
added devopsgovern sectionsec labels
- Resolved by Frédéric Caplette
@zmartins since you helped me by reviewing !127030 (merged), would you mind also reviewing this MR for frontend changes?
- Last reply by Frédéric Caplette
requested review from @zmartins
1 Message 
CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelogtrailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: truetrailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Paulina Sedlak-Jakubowska 
(@psjakubowska) (UTC+2, 8 hours ahead of@mokhax)Samantha Ming (@sming-gitlab) (UTC+2, 8 hours ahead of@mokhax)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-reviewjob that generated this comment.Generated by
Edited by Ghost User
Please start the
trigger-omnibus-and-follow-up-e2ejob in theqastage and ensure the tests infollow-up-e2e:package-and-test-eepipeline are passing before this MR is merged.If you would like to run all e2e tests, please apply the pipeline:run-all-e2e label and trigger a new pipeline. This will run all tests in
e2e:package-and-testpipeline.For the list of known failures please refer to the latest pipeline triage issue.
Once done, please apply the
For any questions or help in reviewing the E2E test results, please reach out on the internal #quality Slack channel.
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 3eab2de8 and f2758686
Entrypoint / Name Size before Size after Diff Diff in percent average 4.15 MB 4.15 MB - -0.0 % mainChunk 3.01 MB 3.01 MB - 0.0 %
Note: We do not have exact data for 3eab2de8. So we have used data from: 486c956e.
The target commit was too new, so we used the latest commit from master we have info on.
It might help to rerun thebundle-size-reviewjob
This might mean that you have a few false positives in this report. If something unrelated to your code changes is reported, you can check this comparison in order to see if they caused this change.Please look at the full report for more details
Read more about how this report works.
Generated by
Allure report
allure-report-publishergenerated test report!e2e-test-on-gdk:
expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 21 | 0 | 0 | 12 | 21 | ❗ | | Plan | 47 | 0 | 0 | 11 | 47 | ❗ | | Create | 19 | 0 | 0 | 18 | 19 | ❗ | | Data Stores | 20 | 0 | 0 | 10 | 20 | ❗ | | Manage | 12 | 0 | 1 | 12 | 13 | ❗ | | Verify | 8 | 0 | 0 | 5 | 8 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 127 | 0 | 1 | 68 | 128 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+e2e-review-qa:
expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Govern | 21 | 0 | 0 | 0 | 21 | ✅ | | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Package | 0 | 0 | 1 | 0 | 1 | ➖ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 39 | 0 | 4 | 0 | 43 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+e2e-package-and-test:
expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 155 | 3 | 12 | 0 | 170 | ❌ | | Create | 150 | 0 | 20 | 0 | 170 | ✅ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Manage | 2 | 0 | 0 | 0 | 2 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 327 | 3 | 36 | 0 | 366 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+Edited by Ghost Userrequested review from @f_caplette and removed review request for @zmartins
@zmartins, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
removed review request for @f_caplette
added 442 commits
-
5399d341...9c216c0c - 441 commits from branch
master - 20c8bb4f - Remove usage of dismissMultipleVulnerabilities feature flag in FE code
-
5399d341...9c216c0c - 441 commits from branch
added 1 commit
- f2758686 - Remove usage of dismissMultipleVulnerabilities feature flag in FE code
