Skip to content

Migrate Admin Groups and Users QA pages to testid

Will Meek requested to merge testid-admin-users-groups into master

What does this MR do and why?

Migrates Admin Groups and Users QA pages QA test attribute from data-qa-selector to data-testid as part of gitlab-org/quality/quality-engineering/team-tasks#1735

Also updates Dangerfile for QA Selector

Screenshots or screen recordings

Screenshots are required for UI changes, and strongly recommended for all other merge requests.

Before After

How to set up and validate locally

Numbered steps to set up and validate the change are strongly suggested.

CHROME_HEADLESS=false bundle exec bin/qa Test::Instance::All http://gdk.test:3000/ ./qa/specs/features/browser_ui/1_manage/login/register_spec.rb


CHROME_HEADLESS=false bundle exec bin/qa Test::Instance::All http://gdk.test:3000/ ./qa/specs/features/ee/browser_ui/1_manage/group/restrict_by_ip_address_spec.rb

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Merge request reports