Keep flyout menu closed when section just got collapsed
What does this MR do and why?
Improves the new flyout menus for the new nav, based on these feedback comments:
Now, when clicking a section title to close its expanded items below, the flyout menu won't appear anymore. It will appear again after the mouse moved away and back onto the section title.
Screenshots or screen recordings
| Before | After |
|---|---|
| recording_1690293035 | recording_1690292963 |
How to set up and validate locally
- These flyout menus were initially not part of the navigation redesign. They are currently still behind their own feature flag, so in your
gdk rails console, run:
Feature.enable(:super_sidebar_flyout_menus)- Then, make sure you have the new navigation toggled on in your user dropdown.
- Browse to any project or group, or the admin page, because their sidebars all have a lot of expandable sections.
- Hover over a collapsed section. You should see the flyout (also on
master) - Click the section title to open it up. The flyout menu disappears (also on
master) - Click the section title again to close it. The flyout should also stay hidden (
🆕 ) - Hover away and back onto the same section title. It shows its flyout again.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #415343 (closed)
Edited by Thomas Hutterer