Skip to content

Include Ci::Deployable in Ci::Bridge

Shinya Maeda requested to merge include-deployable-in-ci-bridge into master

This MR is on top of Move Deployment logic from Ci::Build to Ci::Dep... (!127079 - merged)

What does this MR do and why?

This is a preliminary work for Support `environment` keyword with `trigger` ke... (#369061 - closed) that includes Ci::Deployable module in Ci::Bridge, which was introduced in the previous MR. This gives a capability of being deployable to bridge jobs at model level.

This MR does NOT surface the feature for users yet. Users can't use it until we support the trigger syntax in ci config entries, which will be done in a separate MR.

A few notes:

  • Some traits of FactoryBot are moved from spec/factories/ci/builds.rb to spec/factories/ci/deployable.rb, so that both Ci::Build and Ci::Bridge objects can use the same traits.
  • Test cases are relocated to shared examples as-is. This is for providing the same test coverage for both models.
  • There is a follow-up refactoring/renaming #419755 (closed). This MR is kept as much concise as possible in order to make review eaiser.
  • Rubocop offences are not addressed in this MR in order to make reviews easier. This will be followed-up in a separate MR.
  • You can find PoC in !124562 (closed)

Screenshots or screen recordings

No changes

How to set up and validate locally

No changes

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Edited by Shinya Maeda

Merge request reports