Scoped feature flag by project context
What does this MR do and why?
Need the ability to turn on issues_list_drawer feature flag by project.
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.3
added devopsplan groupproject management typefeature labels
assigned to @donaldcook
added sectiondev label
@mcelicalderonG Please review
requested review from @mcelicalderonG
- A deleted user
added backend label
2 Warnings You've made some app changes, but didn't add any tests.
That's OK as long as you're refactoring existing code,
but please consider adding any of the maintenancepipelines, maintenancerefactor, maintenanceworkflow, documentation, QA labels.Please add a merge request subtype to this merge request. 1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Hinam Mehra (
@hmehra
) (UTC+10, 17 hours ahead of@donaldcook
)Jessie Young (
@jessieay
) (UTC+2, 9 hours ahead of@donaldcook
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost User@mcelicalderonG
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
added featureenhancement label
enabled an automatic merge when the pipeline for 3067d771 succeeds
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 14850a2eexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 51 | 0 | 0 | 44 | 51 | ❗ | | Create | 19 | 0 | 0 | 18 | 19 | ❗ | | Govern | 19 | 0 | 0 | 18 | 19 | ❗ | | Data Stores | 20 | 0 | 0 | 15 | 20 | ❗ | | Manage | 12 | 0 | 1 | 12 | 13 | ❗ | | Verify | 8 | 0 | 0 | 8 | 8 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 129 | 0 | 1 | 115 | 130 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+
mentioned in commit b2a53105
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label