Enable descendant_security_scans by default
What does this MR do and why?
This change includes a backport of !126771 (merged) that enables the descendant_security_scans
feature flag by default to release a bug fix to self managed customers.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
This MR is backporting a bug fix, documentation update, or spec fix, previously merged in the default branch. -
The original MR has been deployed to GitLab.com (not applicable for documentation or spec changes). !126771 (merged) -
This MR has a severity label assigned (if applicable). -
This MR has been approved by a maintainer (only one approval is required). -
Ensure the e2e:package-and-test-ee
job has either succeeded or been approved by a Software Engineer in Test.
Note to the merge request author and maintainer
If you have questions about the patch release process, please:
- Refer to the patch release runbook for engineers and maintainers for guidance.
- Ask questions on the
#releases
Slack channel (internal only).
Merge request reports
Activity
changed milestone to %16.2
assigned to @mokhax
mentioned in issue #393305 (closed)
- A deleted user
added feature flag label
- Resolved by Brian Williams
- Resolved by Brian Williams
1 Warning The e2e:package-and-test-ee
job needs to succeed or have approval from a Software Engineer in Test.
Read the "QA e2e:package-and-test-ee" section for more details.QA
e2e:package-and-test-ee
@mokhax, the
package-and-test
job must complete before merging this merge request.*If there are failures on the
package-and-test
pipeline, ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the#quality
Slack channel.If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger
- Resolved by 🤖 GitLab Bot 🤖
Proper labels assigned to this merge request. Please ignore me.
@mokhax - please see the following guidance and update this merge request.1 Error Please add typebug typefeature, or typemaintenance label to this merge request. Edited by 🤖 GitLab Bot 🤖
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 66eaaabeexpand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Govern | 21 | 0 | 0 | 18 | 21 | ❗ | | Plan | 47 | 0 | 0 | 40 | 47 | ❗ | | Create | 19 | 0 | 0 | 18 | 19 | ❗ | | Data Stores | 20 | 0 | 0 | 15 | 20 | ❗ | | Manage | 12 | 0 | 1 | 12 | 13 | ❗ | | Verify | 8 | 0 | 0 | 8 | 8 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 127 | 0 | 1 | 111 | 128 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 66eaaabeexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 324 | 0 | 5 | 0 | 329 | ✅ | | Create | 697 | 1 | 102 | 4 | 800 | ❌ | | Verify | 188 | 0 | 20 | 0 | 208 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | Monitor | 44 | 0 | 9 | 0 | 53 | ✅ | | Manage | 196 | 0 | 11 | 3 | 207 | ❗ | | Fulfillment | 10 | 0 | 100 | 0 | 110 | ✅ | | Data Stores | 151 | 0 | 3 | 0 | 154 | ✅ | | Package | 267 | 0 | 12 | 0 | 279 | ✅ | | Govern | 208 | 1 | 16 | 13 | 225 | ❌ | | Release | 24 | 0 | 0 | 0 | 24 | ✅ | | Analytics | 9 | 0 | 0 | 0 | 9 | ✅ | | Configure | 1 | 0 | 12 | 0 | 13 | ✅ | | ModelOps | 0 | 0 | 4 | 0 | 4 | ➖ | | Secure | 8 | 0 | 36 | 4 | 44 | ❗ | | Growth | 0 | 0 | 8 | 0 | 8 | ➖ | | Framework sanity | 0 | 0 | 6 | 0 | 6 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 2137 | 2 | 345 | 24 | 2484 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 66eaaabeexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Govern | 21 | 0 | 0 | 0 | 21 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 21 | 0 | 0 | 0 | 21 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test-old-nav:
test report for 66eaaabeexpand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Govern | 102 | 0 | 8 | 0 | 110 | ✅ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 102 | 0 | 8 | 0 | 110 | ✅ | +--------+--------+--------+---------+-------+-------+--------+
mentioned in merge request !126771 (merged)
Setting label groupthreat insights based on
@mokhax
's group.added groupthreat insights label
added bugfunctional label
added typebug label
added devopsgovern sectionsec labels
added severity3 label
changed milestone to %16.3
added missed:16.2 label
marked the checklist item The original MR has been deployed to GitLab.com (not applicable for documentation or spec changes). !126771 (merged) as completed
requested review from @bwill
changed milestone to %16.2
- Resolved by Brian Williams
@bwill
, thanks for approving this merge request.This is the first time the merge request is approved. Please ensure the
e2e:package-and-test-ee
job has succeeded. If there is a failure, a Software Engineer in Test (SET) needs to confirm the failures are unrelated to the merge request. If there's no SET assigned to this team, ask for assistance on the#quality
Slack channel.
added pipeline:run-all-e2e pipeline:run-all-rspec labels
removed missed:16.2 label
- Resolved by Brian Williams
@mokhax Thee2e:package-and-test-ee
job has failed.-
e2e:package-and-test-ee
pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/940447299
e2e:package-and-test-ee
pipeline is allowed to fail due its flakiness. Failures should be investigated to guarantee this backport complies with the Quality standards.Ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the
#quality
Slack channel. -
changed milestone to %16.3
added missed:16.2 label
changed milestone to %16.2
changed milestone to %16.3
enabled an automatic merge when the pipeline for 42193579 succeeds
- Resolved by Brian Williams
@mokhax Thee2e:package-and-test-ee
job has failed.-
e2e:package-and-test-ee
pipeline: https://gitlab.com/gitlab-org/gitlab/-/pipelines/945124476
e2e:package-and-test-ee
pipeline is allowed to fail due its flakiness. Failures should be investigated to guarantee this backport complies with the Quality standards.Ping your team's associated Software Engineer in Test (SET) to confirm the failures are unrelated to the merge request. If there's no SET assigned, ask for assistance on the
#quality
Slack channel. -
mentioned in commit c8943551