Fix report_abuse_button_spec.js
What does this MR do and why?
This is part of the Vue 3 migration > &5102
- Get rid of
wrapper.vm
orchildComponent.vm
modification
Screenshots or screen recordings
Screenshots are required for UI changes, and strongly recommended for all other merge requests.
Before | After |
---|---|
How to set up and validate locally
Numbered steps to set up and validate the change are strongly suggested.
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #413311 (closed)
Merge request reports
Activity
changed milestone to %16.3
assigned to @sming-gitlab
1 Warning 136f6427: The commit subject must contain at least 3 words. For more information, take a look at our Commit message guidelines. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer frontend Rajan Mistry (
@ramistry
) (UTC+5.5, 3.5 hours ahead of@sming-gitlab
)Justin Ho (
@justin_ho
) (UTC+7, 5 hours ahead of@sming-gitlab
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Useradded 175 commits
-
c0bcc760...adf7e937 - 174 commits from branch
master
- 3484dce9 - Fix report_abuse_button_spec.js
-
c0bcc760...adf7e937 - 174 commits from branch
- Resolved by Justin Ho Tuan Duong
@mfluharty can you please review this when you have time?
requested review from @mfluharty
requested review from @justin_ho and removed review request for @mfluharty
@mfluharty
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
- Resolved by Samantha Ming
removed review request for @justin_ho
added 657 commits
-
731ef2a9...c5e4eb4d - 656 commits from branch
master
- 136f6427 - Fix report_abuse_button_spec.js
-
731ef2a9...c5e4eb4d - 656 commits from branch
requested review from @justin_ho