Remove members_with_shared_group_access feature flag
What does this MR do and why?
The feature is fully rolled out and stable.
How to set up and validate locally
Follow the steps given in #377922 (closed)
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #398621 (closed)
Merge request reports
Activity
changed milestone to %16.3
assigned to @abdwdd
- A deleted user
added database databasereview pending labels
1 Warning Please add a merge request subtype to this merge request. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Siddharth Dungarwal (
@sdungarwal
) (UTC+5.5, same timezone as@abdwdd
)Madelein van Niekerk (
@maddievn
) (UTC+2, 3.5 hours behind@abdwdd
)database Max Woolf (
@mwoolf
) (UTC+1, 4.5 hours behind@abdwdd
)Dylan Griffith (
@DylanGriffith
) (UTC+10, 4.5 hours ahead of@abdwdd
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Usermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@538f46bc
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 97a06ca1expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Plan | 51 | 0 | 0 | 45 | 51 | ❗ | | Verify | 8 | 0 | 0 | 8 | 8 | ❗ | | Manage | 13 | 0 | 1 | 12 | 14 | ❗ | | Data Stores | 22 | 0 | 0 | 15 | 22 | ❗ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Create | 27 | 0 | 1 | 20 | 28 | ❗ | | Govern | 21 | 0 | 0 | 18 | 21 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 146 | 0 | 3 | 118 | 149 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 97a06ca1expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 158 | 0 | 18 | 0 | 176 | ✅ | | Plan | 9 | 0 | 1 | 0 | 10 | ✅ | | Manage | 60 | 0 | 3 | 5 | 63 | ❗ | | Systems | 8 | 0 | 0 | 0 | 8 | ✅ | | GitLab Metrics | 2 | 0 | 1 | 0 | 3 | ✅ | | Package | 25 | 0 | 0 | 0 | 25 | ✅ | | Fulfillment | 2 | 0 | 0 | 0 | 2 | ✅ | | Govern | 5 | 0 | 0 | 0 | 5 | ✅ | | Monitor | 12 | 0 | 1 | 0 | 13 | ✅ | | Analytics | 1 | 0 | 0 | 0 | 1 | ✅ | | Configure | 1 | 0 | 0 | 0 | 1 | ✅ | | Data Stores | 15 | 0 | 3 | 0 | 18 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 298 | 0 | 29 | 5 | 327 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost User- Resolved by Joe Woodward
Hiding whitespace changes will make it easier to review.
@terrichu @jwoodwardgl could you please review database and backend respectively?
requested review from @terrichu and @jwoodwardgl
added databasereviewed label and removed databasereview pending label
requested review from @dfrazao-gitlab and removed review request for @terrichu
@terrichu
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@9602f942
added databaseapproved label and removed databasereviewed label
- Resolved by Aleksei Lipniagov
@alipniagov could you do the backend maintainer review please?
requested review from @alipniagov and removed review request for @jwoodwardgl
enabled an automatic merge when the pipeline for bcf4fba9 succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@bcf4fba9
mentioned in commit 89b23a69
mentioned in issue #398621 (closed)
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2364 (merged)
requested review from @jwoodwardgl and removed review request for @dfrazao-gitlab