Remove free_user_cap_new_namespaces feature flag
What
- Remove free_user_cap_new_namespaces feature flag
- Removes all code related to new namespace as it relates to free user cap enforcement. We now treat them all the same and will only drive off of the application setting of
dashboard_limit
anddashboard_limit_enabled
Why
No longer needed as we've completely cut over to free user cap enforcement for all namespaces and no longer need to consider 'new namespaces' differently than other namespaces.
Currently in production dashboard_limit
and dashboard_enforcement_limit
are the same value of 5. This feature is gated fully by .com?
and the dashboard_limit_enabled
checks that ensure it only operates on SaaS
#415485 for more details
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #415485
Merge request reports
Activity
changed milestone to %16.2
assigned to @dstull
1 Warning This merge request is quite big (573 lines changed), please consider splitting it into multiple merge requests. Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Gregorius Marco (
@marcogreg
) (UTC+8, 12 hours ahead of@dstull
)Laura Montemayor (
@lauraX
) (UTC+2, 6 hours ahead of@dstull
)frontend Sharmad Nachnolkar (
@snachnolkar
) (UTC+5.5, 9.5 hours ahead of@dstull
)Andrew Fontaine (
@afontaine
) (UTC-6, 2 hours behind@dstull
)test for spec/features/*
Gregorius Marco (
@marcogreg
) (UTC+8, 12 hours ahead of@dstull
)Maintainer review is optional for test for spec/features/*
To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Usermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@9d22d145
Bundle size analysis [beta]
This compares changes in bundle size for entry points between the commits 042a8cf8 and 82a77526
Special assetsEntrypoint / Name Size before Size after Diff Diff in percent average 4.14 MB 4.14 MB - -0.0 % mainChunk 3.01 MB 3.01 MB - 0.0 %
Note: We do not have exact data for 042a8cf8. So we have used data from: 694d5cd7.
The intended commit has no webpack pipeline, so we chose the last commit with one before it.Please look at the full report for more details
Read more about how this report works.
Generated by
DangerEdited by Ghost UserAllure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 1374e567expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 47 | 0 | 0 | 40 | 47 | ❗ | | Data Stores | 20 | 0 | 0 | 15 | 20 | ❗ | | Govern | 19 | 0 | 0 | 15 | 19 | ❗ | | Manage | 12 | 0 | 1 | 12 | 13 | ❗ | | Create | 19 | 0 | 0 | 18 | 19 | ❗ | | Verify | 8 | 0 | 0 | 8 | 8 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 125 | 0 | 1 | 108 | 126 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for 82a77526expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 1 | 9 | ❗ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Monitor | 3 | 1 | 0 | 0 | 4 | ❌ | | Govern | 0 | 2 | 0 | 0 | 2 | ❌ | | Manage | 0 | 1 | 0 | 0 | 1 | ❌ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 16 | 4 | 3 | 1 | 23 | ❌ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 1374e567expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 151 | 0 | 19 | 1 | 170 | ❗ | | Growth | 0 | 0 | 8 | 0 | 8 | ➖ | | Govern | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 8 | 0 | 0 | 0 | 8 | ✅ | | Manage | 2 | 0 | 0 | 0 | 2 | ✅ | | Framework sanity | 0 | 0 | 2 | 0 | 2 | ➖ | | Monitor | 8 | 0 | 0 | 0 | 8 | ✅ | | Data Stores | 4 | 0 | 0 | 0 | 4 | ✅ | | Package | 0 | 0 | 2 | 0 | 2 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 177 | 0 | 31 | 1 | 208 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
Edited by Ghost Useradded 1 commit
- 30d3e6e5 - Remove free_user_cap_new_namespace feature flag and code
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@82b279cd
added 1 commit
- 82a77526 - Remove free_user_cap_new_namespace feature flag and code
added pipeline:run-all-rspec label
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@e1192b13
added 537 commits
-
82a77526...5ce2b780 - 534 commits from branch
master
- 48e31aa1 - Remove free_user_cap_new_namespaces feature flag
- ba6cf089 - Remove preview_free_user cap and all related code
- f5c5eb73 - Remove free_user_cap_new_namespace feature flag and code
Toggle commit list-
82a77526...5ce2b780 - 534 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@aad8001f
added 1 commit
- 53a3e757 - Remove free_user_cap_new_namespace feature flag and code
added 1 commit
- 0141690a - Remove free_user_cap_new_namespace feature flag and code
- Resolved by Nicolas Dular