Style/RedundantFreeze: Fix offenses in app/
What does this MR do and why?
This MR fixes some offenses for Style/RedundantFreeze
.
Regexp
andRange
literals are frozen objects since Ruby 3.0.From Ruby 3.0, this cop allows explicit freezing of interpolated string literals when
# frozen-string-literal: true
is used.
Auto-corrected via:
rubocop -a --only Style/RedundantFreeze app

MR train

- Style/RedundantFreeze: Fix offenses in rubocop,... (!126506 - merged)
- Style/RedundantFreeze: Fix offenses in EE (!126508 - merged)
-
Style/RedundantFreeze: Fix offenses in app/ (!126510 - closed)
YOU ARE HERE - Style/RedundantFreeze: Fix offenses in lib/gitl... (!126513 - closed)
- Style/RedundantFreeze: Fix offenses in lib/[a-f... (!126516 - closed)
- Style/RedundantFreeze: Fix offenses in lib (!126519 - closed)
How to set up and validate locally
REVEAL_RUBOCOP_TODO=1 rubocop --only Style/RedundantFreeze app
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
assigned to @splattael
changed milestone to %16.2
mentioned in merge request !126506 (merged)
mentioned in merge request !126508 (merged)
marked the checklist item I have evaluated the MR acceptance checklist for this MR. as completed
removed QA label
mentioned in issue Taucher2003/reporting#36 (closed)
- A deleted user
added database databasereview pending labels
1 Message This merge request adds or changes files that require a review from the Database team. This merge request requires a database review. To make sure these changes are reviewed, take the following steps:
- Ensure the merge request has database and databasereview pending labels. If the merge request modifies database files, Danger will do this for you.
- Prepare your MR for database review according to the docs.
- Assign and mention the database reviewer suggested by Reviewer Roulette.
The following files require a review from the Database team:
app/finders/repositories/changelog_commits_finder.rb
app/finders/issuable_finder.rb
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Jerry Seto (
@j.seto
) (UTC-4, 6 hours behind@splattael
)Matt Kasa (
@mattkasa
) (UTC-7, 9 hours behind@splattael
)database Mehmet Emin Inac (
@minac
) (UTC+2, same timezone as@splattael
)Dylan Griffith (
@DylanGriffith
) (UTC+10, 8 hours ahead of@splattael
)groupimport and integrate (backend) Bojan Marjanović (
@bmarjanovic
) (UTC+2, same timezone as@splattael
)Maintainer review is optional for groupimport and integrate (backend) ~"group::authentication and authorization" Reviewer review is optional for ~"group::authentication and authorization" Małgorzata Ksionek (
@mksionek
) (UTC+2, same timezone as@splattael
)~"Verify" Reviewer review is optional for ~"Verify" Stan Hu (
@stanhu
) (UTC-7, 9 hours behind@splattael
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
DangerEdited by Ghost Usermentioned in merge request !126513 (closed)
mentioned in merge request !126516 (closed)
added 3 commits
-
638bb7f6...84b8f80d - 2 commits from branch
pl-rubocop-fix-style-redundant-freeze-2
- 316f4ae9 - Style/RedundantFreeze: Fix offenses in app/
-
638bb7f6...84b8f80d - 2 commits from branch
mentioned in merge request !126519 (closed)
changed milestone to %16.3
added missed:16.2 label