Add read_dependency column to member_roles table
What does this MR do and why?
This change adds a new column to the member_roles
table for the read_dependency
ability. This column is used to enable the read_dependencies
permission when member_roles.read_dependency
is enabled on a custom member role.
Add read_dependency column to member_roles table
This change adds a new column to the member_roles
table to allow
custom roles to enable the read_dependency
ability.
Changelog: added EE: true
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Merge request reports
Activity
changed milestone to %16.3
added featureaddition groupthreat insights labels
assigned to @mokhax
added typefeature label
added devopsgovern sectionsec labels
- A deleted user
added database databasereview pending labels
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Rad Batnag (
@radbatnag
) (UTC+8)Rajendra Kadam (
@rkadam3
) (UTC+5.5)database Mehmet Emin Inac (
@minac
) (UTC+2)Matt Kasa (
@mattkasa
) (UTC-7)~"migration" No reviewer available No maintainer available To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Danger- A deleted user
added Data WarehouseImpact Check label
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for da60e762expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 47 | 0 | 0 | 41 | 47 | ❗ | | Govern | 21 | 0 | 0 | 18 | 21 | ❗ | | Data Stores | 20 | 0 | 0 | 15 | 20 | ❗ | | Create | 19 | 0 | 0 | 18 | 19 | ❗ | | Verify | 8 | 0 | 0 | 8 | 8 | ❗ | | Manage | 12 | 0 | 1 | 12 | 13 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 127 | 0 | 1 | 112 | 128 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-review-qa:
test report for be875854expand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Create | 8 | 0 | 1 | 0 | 9 | ✅ | | Govern | 21 | 0 | 0 | 0 | 21 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Plan | 3 | 0 | 1 | 0 | 4 | ✅ | | Data Stores | 2 | 0 | 0 | 0 | 2 | ✅ | | Manage | 1 | 0 | 0 | 0 | 1 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 39 | 0 | 3 | 0 | 42 | ✅ | +------------------+--------+--------+---------+-------+-------+--------+
added 1 commit
- 9432e4e2 - Add policy to enable read_dependeny via custom roles
- A deleted user
added backend label
- Resolved by Max Woolf
- Resolved by Max Woolf
- Resolved by euko
Database migrations (on the main database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20230712214613 - AddReadDependencyToMemberRoles Regular 2.1 s +0.00 B Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 4 0.1 seconds - 1 second 0 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20230712214613 - AddReadDependencyToMemberRoles
- Type: Regular
- Duration: 2.1 s
- Database size change: +0.00 B
Calls Total Time Max Time Mean Time Rows Query 1 9.1 ms 9.1 ms 9.1 ms 0 ALTER TABLE "member_roles" ADD "read_dependency" boolean DEFAULT FALSE NOT NULL
2 0.0 ms 0.0 ms 0.0 ms 2 SELECT pg_backend_pid()
1 0.0 ms 0.0 ms 0.0 ms 1 SELECT $1::regtype::oid
Histogram for AddReadDependencyToMemberRoles
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 4 0.1 seconds - 1 second 0 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Other information
Other migrations pending on GitLab.com
Migration Type Total runtime Result DB size change 20230704050739 - PrepareRemovalIndexDeploymentsOnEnvironmentIdAndIidAndProjectId Post deploy 3.1 s +0.00 B 20230705141703 - RollbackVulnerabilityAdvisoriesForeignKeyOnVulnerableComponentVersions Post deploy 1.5 s +0.00 B 20230705141733 - RollbackComponentVersionForeignKeyOnVulnerableComponentVersions Post deploy 2.3 s +0.00 B 20230705142241 - DropVulnerableComponentVersions Post deploy 1.9 s -32.00 KiB 20230705142334 - DropVulnerabilitiesAdvisories Post deploy 1.8 s -24.00 KiB 20230707220646 - AddIndexToVulnerabilityFindingsOnUuidAgain Post deploy 2.3 s +0.00 B 20230711093010 - DropDefaultPartitionIdValueForCiTables Post deploy 4.3 s +0.00 B 20230712020407 - RemoveTemporaryIndexFromSystemNoteMetadata Post deploy 2.2 s -7.05 MiB 20230712064637 - ReplaceOldFkPCiBuildsMetadataToBuildsV2 Post deploy 2.0 s +0.00 B 20230712064655 - ReplaceOldFkPCiRunnerMachineBuildsToBuildsV2 Post deploy 1.7 s +0.00 B 20230712145323 - DropCiJobArtifactsPartitionIdDefault Post deploy 1.8 s +0.00 B 20230712145821 - DropCiStagesPartitionIdDefault Post deploy 1.8 s +0.00 B 20230712145926 - DropCiBuildTraceMetadataPartitionIdDefault Post deploy 1.8 s +0.00 B 20230713100100 - DropCiPipelineVariablePartitionIdDefault Post deploy 1.8 s +0.00 B Clone details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-2111817-10591323-main
2023-07-13T21:59:55Z 2023-07-13T16:39:26Z 2023-07-14 10:04:50 +0000 database-testing-2111817-10591323-ci
2023-07-13T21:59:55Z 2023-07-13T20:45:31Z 2023-07-14 10:04:50 +0000 Database migrations (on the ci database)
Migrations included in this change have been executed on gitlab.com data for testing purposes. For details, please see the migration testing pipeline (limited access).
Migration Type Total runtime Result DB size change 20230712214613 - AddReadDependencyToMemberRoles Regular 3.5 s +0.00 B Runtime Histogram for all migrations
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 4 0.1 seconds - 1 second 0 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Migration: 20230712214613 - AddReadDependencyToMemberRoles
- Type: Regular
- Duration: 3.5 s
- Database size change: +0.00 B
Calls Total Time Max Time Mean Time Rows Query 1 12.6 ms 12.6 ms 12.6 ms 0 ALTER TABLE "member_roles" ADD "read_dependency" boolean DEFAULT FALSE NOT NULL
1 0.0 ms 0.0 ms 0.0 ms 1 SELECT $1::regtype::oid
2 0.0 ms 0.0 ms 0.0 ms 2 SELECT pg_backend_pid()
Histogram for AddReadDependencyToMemberRoles
Query Runtime Count 0 seconds - 0.01 seconds 0 0.01 seconds - 0.1 seconds 4 0.1 seconds - 1 second 0 1 second - 5 seconds 0 5 seconds - 15 seconds 0 15 seconds - 5 minutes 0 5 minutes + 0 Other information
Other migrations pending on GitLab.com
Migration Type Total runtime Result DB size change 20230704050739 - PrepareRemovalIndexDeploymentsOnEnvironmentIdAndIidAndProjectId Post deploy 3.8 s +0.00 B 20230705141703 - RollbackVulnerabilityAdvisoriesForeignKeyOnVulnerableComponentVersions Post deploy 2.4 s +0.00 B 20230705141733 - RollbackComponentVersionForeignKeyOnVulnerableComponentVersions Post deploy 2.4 s +0.00 B 20230705142241 - DropVulnerableComponentVersions Post deploy 2.5 s -32.00 KiB 20230705142334 - DropVulnerabilitiesAdvisories Post deploy 2.5 s -24.00 KiB 20230707220646 - AddIndexToVulnerabilityFindingsOnUuidAgain Post deploy 2.5 s +0.00 B 20230711093010 - DropDefaultPartitionIdValueForCiTables Post deploy 5.4 s +0.00 B 20230712020407 - RemoveTemporaryIndexFromSystemNoteMetadata Post deploy 3.1 s -8.00 KiB 20230712064637 - ReplaceOldFkPCiBuildsMetadataToBuildsV2 Post deploy 3.6 s +0.00 B 20230712064655 - ReplaceOldFkPCiRunnerMachineBuildsToBuildsV2 Post deploy 3.2 s +0.00 B 20230712145323 - DropCiJobArtifactsPartitionIdDefault Post deploy 2.7 s +0.00 B 20230712145821 - DropCiStagesPartitionIdDefault Post deploy 2.7 s +0.00 B 20230712145926 - DropCiBuildTraceMetadataPartitionIdDefault Post deploy 2.7 s +0.00 B 20230713100100 - DropCiPipelineVariablePartitionIdDefault Post deploy 2.7 s +0.00 B Clone details
Clone ID Clone Created At Clone Data Timestamp Expected Removal Time database-testing-2111817-10591323-main
2023-07-13T21:59:55Z 2023-07-13T16:39:26Z 2023-07-14 10:04:50 +0000 database-testing-2111817-10591323-ci
2023-07-13T21:59:55Z 2023-07-13T20:45:31Z 2023-07-14 10:04:50 +0000
Brought to you by gitlab-org/database-team/gitlab-com-database-testing. Epic
added 1 commit
- 96e5bb75 - Update assertion to include read_dependency ability
- A deleted user
added database-testing-automation label
mentioned in issue #415255 (closed)
mentioned in epic &10684 (closed)
added 212 commits
-
96e5bb75...e1c3acde - 208 commits from branch
master
- 8fa73e35 - Add read_dependency column to member_roles table
- 27a9735f - Add policy to enable read_dependeny via custom roles
- d881da38 - Ensure dependency_scanning is enabled
- 17d74aa0 - Update assertion to include read_dependency ability
Toggle commit list-
96e5bb75...e1c3acde - 208 commits from branch
- Resolved by Max Woolf
@aakriti.gupta would you mind reviewing this MR for backend changes?
@terrichu would you mind reviewing this MR for database changes?
requested review from @aakriti.gupta and @terrichu
added databasereviewed label and removed databasereview pending label
@terrichu
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
added databaseapproved label and removed databasereviewed label
removed review request for @euko
added Data WarehouseNot Impacted label and removed Data WarehouseImpact Check label
- Resolved by Aakriti Gupta
- Resolved by Aakriti Gupta
- Resolved by Max Woolf
I have left suggestions.
Please feel free to assign back to me by UTC morning tomorrow, after addressing them, otherwise, please re-assign since I am on vacation starting Wednesday, July 19th. (only available until 12pm UTC tomorrow)
removed review request for @aakriti.gupta
added 1 commit
- da60e762 - Enable read_dependency for one of them members in the test fixture
requested review from @aakriti.gupta
requested review from @mwoolf and removed review request for @aakriti.gupta
enabled an automatic merge when the pipeline for e3c9f389 succeeds
@mwoolf, did you forget to run a pipeline before you merged this work? Based on our code review process, if the latest pipeline was created more than 6 hours ago OR finished more than 2 hours ago, you should:
- Ensure the merge request is not in Draft status.
- Start a pipeline (especially important for Community contribution merge requests).
- Set the merge request to auto-merge.
This is a guideline, not a rule. Please consider replying to this comment for transparency.
This message was generated automatically. You're welcome to improve it.
Hello @mokhax
The database team is looking for ways to improve the database review process and we would love your help!
If you'd be open to someone on the database team reaching out to you for a chat, or if you'd like to leave some feedback asynchronously, just post a reply to this comment mentioning:
@gitlab-org/database-team
And someone will be by shortly!
Thanks for your help!
This message was generated automatically. You're welcome to improve it.
mentioned in commit f1cfee0c
added workflowstaging-canary label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2281 (merged)
added releasedpublished label and removed releasedcandidate label
mentioned in issue gitlab-com/www-gitlab-com#8670 (closed)
mentioned in issue #451035 (closed)