Skip to content
Snippets Groups Projects

Allow excluding archived projects from merge request search

All threads resolved!

What does this MR do and why?

Enables excluding merge requests from archived projects from search results behind a feature flag search_merge_requests_hide_archived_projects

  1. Add archived (boolean) to merge request mappings
  2. Backfill archived for all merge requests in the index
  3. Add a filter for excluding archived projects if the option include_archived is not true (only if the migrations are finished and the feature flag is enabled)

How to set up and validate locally

  1. Ensure elasticsearch is running
  2. Run the migration worker a few times to execute the migrations
  3. Disable the feature flag Feature.disable(:search_merge_requests_hide_archived_projects)
  4. Find a project with a merge request
  5. Do search for the merge request: the merge request should be in the results
  6. Enable the feature flag Feature.enablesearch_merge_requests_hide_archived_projects)
  7. Do search for the merge request: the merge request should be in the results
  8. Archive the project
  9. Do search for the merge request: the merge request should NOT be in the results
  10. Do search for the merge request with the param include_archived=true: the merge request should be in the results
  11. Repeat steps 2-10 with the added param basic_search=true

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #414904 (closed)

Edited by Madelein van Niekerk

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
  • Ghost User
  • added 1 commit

    Compare with previous version

  • Madelein van Niekerk resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • Madelein van Niekerk
  • Madelein van Niekerk
  • Madelein van Niekerk changed the description

    changed the description

  • requested review from @sdungarwal

  • Siddharth Dungarwal removed review request for @sdungarwal

    removed review request for @sdungarwal

  • added 1 commit

    Compare with previous version

  • requested review from @sdungarwal

  • Madelein van Niekerk added 1540 commits

    added 1540 commits

    • 549f40f2...4c540580 - 1538 commits from branch master
    • 1fc5ac09 - Exclude archived projects from merge request search
    • fd46c24d - Adds migration dictionary records for migrations

    Compare with previous version

  • Ghost User
  • Ghost User
  • Siddharth Dungarwal requested review from @dgruzd and removed review request for @sdungarwal

    requested review from @dgruzd and removed review request for @sdungarwal

  • added 1 commit

    • 7e0e11cb - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Madelein van Niekerk added 168 commits

    added 168 commits

    • 7e0e11cb...6b838d59 - 165 commits from branch master
    • 76080aaa - Exclude archived projects from merge request search
    • a544a7e9 - Adds migration dictionary records for migrations
    • 270babce - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Dmitry Gruzd approved this merge request

    approved this merge request

  • Dmitry Gruzd resolved all threads

    resolved all threads

  • :wave: @dgruzd, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Dmitry Gruzd changed milestone to %16.3

    changed milestone to %16.3

  • Dmitry Gruzd enabled an automatic merge when the pipeline for a69af4ca succeeds

    enabled an automatic merge when the pipeline for a69af4ca succeeds

  • merged

  • Dmitry Gruzd mentioned in commit d7fce20e

    mentioned in commit d7fce20e

  • added workflowstaging label and removed workflowcanary label

  • Dmitry Gruzd mentioned in merge request !134621 (merged)

    mentioned in merge request !134621 (merged)

  • Please register or sign in to reply
    Loading