Allow excluding archived projects from merge request search
What does this MR do and why?
Enables excluding merge requests from archived projects from search results behind a feature flag search_merge_requests_hide_archived_projects
- Add
archived
(boolean) to merge request mappings - Backfill
archived
for all merge requests in the index - Add a filter for excluding archived projects if the option
include_archived
is not true (only if the migrations are finished and the feature flag is enabled)
How to set up and validate locally
- Ensure elasticsearch is running
- Run the migration worker a few times to execute the migrations
- Disable the feature flag
Feature.disable(:search_merge_requests_hide_archived_projects)
- Find a project with a merge request
- Do search for the merge request: the merge request should be in the results
- Enable the feature flag
Feature.enablesearch_merge_requests_hide_archived_projects)
- Do search for the merge request: the merge request should be in the results
- Archive the project
- Do search for the merge request: the merge request should NOT be in the results
- Do search for the merge request with the param
include_archived=true
: the merge request should be in the results - Repeat steps 2-10 with the added param
basic_search=true
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #414904 (closed)
Merge request reports
Activity
changed milestone to %16.2
assigned to @maddievn
- A deleted user
added backend feature flag labels
2 Warnings This MR changes code in ee/
, but its Changelog commit is missing theEE: true
trailer. Consider adding it to your Changelog commits.featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Michał Wielich (
@michold
) (UTC+2, same timezone as@maddievn
)Tetiana Chupryna (
@brytannia
) (UTC+2, same timezone as@maddievn
)~"Global Search" Reviewer review is optional for ~"Global Search" Terri Chu (
@terrichu
) (UTC-4, 6 hours behind@maddievn
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangermentioned in commit gitlab-org-sandbox/gitlab-jh-validation@e9b7df72
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@be950db0
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 270babceexpand test summary
+-----------------------------------------------------------------------+ | suites summary | +------------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +------------------+--------+--------+---------+-------+-------+--------+ | Govern | 21 | 0 | 0 | 18 | 21 | ❗ | | Plan | 51 | 0 | 0 | 45 | 51 | ❗ | | Manage | 13 | 0 | 1 | 12 | 14 | ❗ | | Data Stores | 22 | 0 | 0 | 15 | 22 | ❗ | | Create | 27 | 0 | 1 | 20 | 28 | ❗ | | Verify | 8 | 0 | 0 | 8 | 8 | ❗ | | Monitor | 4 | 0 | 0 | 0 | 4 | ✅ | | Framework sanity | 0 | 0 | 1 | 0 | 1 | ➖ | +------------------+--------+--------+---------+-------+-------+--------+ | Total | 146 | 0 | 3 | 118 | 149 | ❗ | +------------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 270babceexpand test summary
+------------------------------------------------------------+ | suites summary | +-------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------+--------+--------+---------+-------+-------+--------+ +-------+--------+--------+---------+-------+-------+--------+ | Total | 0 | 0 | 0 | 0 | 0 | ➖ | +-------+--------+--------+---------+-------+-------+--------+
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@528e0ca5
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@57599054
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@05f3249d
- Resolved by Madelein van Niekerk
- Resolved by Madelein van Niekerk
- Resolved by Madelein van Niekerk
- Resolved by Madelein van Niekerk
- Resolved by Madelein van Niekerk
- Resolved by Madelein van Niekerk
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@cacc0d49
- Resolved by Madelein van Niekerk
- Resolved by Madelein van Niekerk
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@e2ca0bb2
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@edbcc1f1
- Resolved by Madelein van Niekerk
- Resolved by Madelein van Niekerk
- Resolved by Dmitry Gruzd
@sdungarwal can you please do the initial review and pass to
@dgruzd
for final review?
requested review from @sdungarwal
- Resolved by Madelein van Niekerk
removed review request for @sdungarwal
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@d488f2b4
requested review from @sdungarwal
added 1540 commits
-
549f40f2...4c540580 - 1538 commits from branch
master
- 1fc5ac09 - Exclude archived projects from merge request search
- fd46c24d - Adds migration dictionary records for migrations
-
549f40f2...4c540580 - 1538 commits from branch
- Resolved by Madelein van Niekerk
- Resolved by Madelein van Niekerk
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@f1124820
- Resolved by Madelein van Niekerk
requested review from @dgruzd and removed review request for @sdungarwal
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@688c89e4
added 168 commits
-
7e0e11cb...6b838d59 - 165 commits from branch
master
- 76080aaa - Exclude archived projects from merge request search
- a544a7e9 - Adds migration dictionary records for migrations
- 270babce - Apply 1 suggestion(s) to 1 file(s)
Toggle commit list-
7e0e11cb...6b838d59 - 165 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@8e3d5fc4
@dgruzd
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
changed milestone to %16.3
enabled an automatic merge when the pipeline for a69af4ca succeeds
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@a69af4ca
mentioned in commit d7fce20e
added workflowstaging-canary label and removed workflowin dev label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in merge request kubitus-project/kubitus-installer!2364 (merged)
mentioned in merge request !134621 (merged)