Check changes for files over a limit
What does this MR do and why?
Check changes for files over a limit
Log when changes would exceed a global limit.
In a future MR we will add a non-hardcoded limit (based on plan tier or something other configuration) that will prevent pushes that contain files over the limit.
Contributes to: #393535 (closed)
How to setup and validate locally
Try some variations of things like:
- Create a new project
- Enable the global_file_size_check feature flag
- Push a file that's over 2 MB (
head -c 2097153 /dev/urandom > 2_MB_plus_1_byte
) - Settings -> Repository -> Expand
Push rules
-> SetMaximum file size (MB)
to 2 MB - Try to push a file that is larger than 2 MB see that oversize file is logged. (e.g
head -c 2097153 /dev/urandom > new_2_MB_plus_1_byte
) - Try appending to to the first file (
echo 'changes' >> 2_MB_plus_1_byte
) and see that there's no log for the oversize file
MR acceptance checklist
This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.
-
I have evaluated the MR acceptance checklist for this MR.
Related to #393535 (closed)
Merge request reports
Activity
changed milestone to %16.2
assigned to @j.seto
- A deleted user
added feature flag label
- Resolved by Jerry Seto
- Resolved by Jerry Seto
1 Warning featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.
For more information, see:
- The Handbook page on merge request types.
- The definition of done documentation.
1 Message CHANGELOG missing: If you want to create a changelog entry for GitLab FOSS, add the
Changelog
trailer to the commit message you want to add to the changelog.If you want to create a changelog entry for GitLab EE, also add the
EE: true
trailer to your commit message.If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.
Reviewer roulette
Changes that require review have been detected!
Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:
Category Reviewer Maintainer backend Siddharth Dungarwal (
@sdungarwal
) (UTC+5.5, 9.5 hours ahead of@j.seto
)Kerri Miller (
@kerrizor
) (UTC-7, 3 hours behind@j.seto
)To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.
To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.
Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.
If needed, you can retry the
danger-review
job that generated this comment.Generated by
Dangeradded 1075 commits
-
c21aaa9e...5c84854f - 1073 commits from branch
393535-new-strategy
- c78b0ee1 - Check changes for files over a limit
- 51c36473 - Add MR url
-
c21aaa9e...5c84854f - 1073 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@02a6f2a9
Allure report
allure-report-publisher
generated test report!e2e-test-on-gdk:
test report for 7cf18b21expand test summary
+------------------------------------------------------------------+ | suites summary | +-------------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +-------------+--------+--------+---------+-------+-------+--------+ | Plan | 47 | 0 | 0 | 41 | 47 | ❗ | | Create | 27 | 0 | 1 | 20 | 28 | ❗ | | Manage | 12 | 0 | 1 | 12 | 13 | ❗ | | Data Stores | 20 | 0 | 0 | 15 | 20 | ❗ | | Govern | 19 | 0 | 0 | 18 | 19 | ❗ | | Verify | 8 | 0 | 0 | 8 | 8 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+ | Total | 133 | 0 | 2 | 114 | 135 | ❗ | +-------------+--------+--------+---------+-------+-------+--------+
e2e-package-and-test:
test report for 7cf18b21expand test summary
+-------------------------------------------------------------+ | suites summary | +--------+--------+--------+---------+-------+-------+--------+ | | passed | failed | skipped | flaky | total | result | +--------+--------+--------+---------+-------+-------+--------+ | Create | 270 | 0 | 32 | 2 | 302 | ❗ | +--------+--------+--------+---------+-------+-------+--------+ | Total | 270 | 0 | 32 | 2 | 302 | ❗ | +--------+--------+--------+---------+-------+-------+--------+
added 6 commits
-
51c36473...1a0a5787 - 5 commits from branch
393535-new-strategy
- ae8aed23 - Check changes for files over a limit
-
51c36473...1a0a5787 - 5 commits from branch
added 584 commits
-
ae8aed23...6a37793f - 583 commits from branch
393535-new-strategy
- 11361cb0 - Check changes for files over a limit
-
ae8aed23...6a37793f - 583 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@141f579a
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@a135db8e
mentioned in merge request !125245 (merged)
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@ee1761d7
added 3 commits
-
ff5db0ba...530ffc05 - 2 commits from branch
393535-new-strategy
- 51438ee7 - Check changes for files over a limit
-
ff5db0ba...530ffc05 - 2 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@c6cb5bcf
- Resolved by Alper Akgun
hi @jpcyiza
can you please do the initial review for this?
requested review from @jpcyiza
- Resolved by Jerry Seto
@jpcyiza
, thanks for approving this merge request.This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.
For more info, please refer to the following links:
added pipeline:mr-approved label
requested review from @a_akgun
- Resolved by Jerry Seto
- Resolved by Alper Akgun
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@c1cfdf98
- Resolved by Alper Akgun
Thanks @j.seto LGTM.
removed review request for @jpcyiza
added 864 commits
-
0f4de86f...560e11ea - 862 commits from branch
master
- a4b6b6b4 - Check changes for files over a limit
- 7cf18b21 - Log when checking for blob and refactor
-
0f4de86f...560e11ea - 862 commits from branch
mentioned in commit gitlab-org-sandbox/gitlab-jh-validation@533d4294
changed milestone to %16.3
enabled an automatic merge when the pipeline for 533d4294 succeeds
mentioned in commit a2833ffa
added workflowstaging-canary label and removed workflowin review label
added workflowcanary label and removed workflowstaging-canary label
added workflowstaging label and removed workflowcanary label
added workflowproduction label and removed workflowstaging label
added workflowpost-deploy-db-staging label and removed workflowproduction label
added workflowpost-deploy-db-production label and removed workflowpost-deploy-db-staging label
added releasedcandidate label
added releasedpublished label and removed releasedcandidate label
mentioned in issue gitlab-org/quality/triage-reports#15273 (closed)
mentioned in issue gitlab-org/quality/triage-reports#15701 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16006 (closed)
mentioned in issue gitlab-org/quality/triage-reports#16469 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17003 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17453 (closed)
mentioned in issue gitlab-org/quality/triage-reports#17912 (closed)
mentioned in issue #467556 (closed)
mentioned in issue #469079
mentioned in issue gitlab-org/quality/triage-reports#18445 (closed)
mentioned in issue gitlab-org/quality/triage-reports#18926 (closed)
mentioned in issue gitlab-org/quality/triage-reports#19380 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20597 (closed)
mentioned in issue gitlab-org/quality/triage-reports#20960 (closed)
mentioned in issue gitlab-org/quality/triage-reports#21530 (closed)
mentioned in issue gitlab-org/quality/triage-reports#22034