Skip to content
Snippets Groups Projects

Check changes for files over a limit

Merged Jerry Seto requested to merge 393535-integrate-new-strategy into master
All threads resolved!

What does this MR do and why?

Check changes for files over a limit

Log when changes would exceed a global limit.

In a future MR we will add a non-hardcoded limit (based on plan tier or something other configuration) that will prevent pushes that contain files over the limit.

Contributes to: #393535 (closed)

How to setup and validate locally

Try some variations of things like:

  1. Create a new project
  2. Enable the global_file_size_check feature flag
  3. Push a file that's over 2 MB (head -c 2097153 /dev/urandom > 2_MB_plus_1_byte)
  4. Settings -> Repository -> Expand Push rules -> Set Maximum file size (MB) to 2 MB
  5. Try to push a file that is larger than 2 MB see that oversize file is logged. (e.g head -c 2097153 /dev/urandom > new_2_MB_plus_1_byte)
  6. Try appending to to the first file (echo 'changes' >> 2_MB_plus_1_byte) and see that there's no log for the oversize file

MR acceptance checklist

This checklist encourages us to confirm any changes have been analyzed to reduce risks in quality, performance, reliability, security, and maintainability.

Related to #393535 (closed)

Edited by Jerry Seto

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ghost User
  • Contributor
    1 Warning
    :warning:

    featureaddition and featureenhancement merge requests normally have a documentation change. Consider adding a documentation update or confirming the documentation plan with the Technical Writer counterpart.

    For more information, see:

    1 Message
    :book: CHANGELOG missing:

    If you want to create a changelog entry for GitLab FOSS, add the Changelog trailer to the commit message you want to add to the changelog.

    If you want to create a changelog entry for GitLab EE, also add the EE: true trailer to your commit message.

    If this merge request doesn't need a CHANGELOG entry, feel free to ignore this message.

    Reviewer roulette

    Changes that require review have been detected!

    Please refer to the table below for assigning reviewers and maintainers suggested by Danger in the specified category:

    Category Reviewer Maintainer
    backend Siddharth Dungarwal current availability (@sdungarwal) (UTC+5.5, 9.5 hours ahead of @j.seto) Kerri Miller current availability (@kerrizor) (UTC-7, 3 hours behind @j.seto)

    To spread load more evenly across eligible reviewers, Danger has picked a candidate for each review slot, based on their timezone. Feel free to override these selections if you think someone else would be better-suited or use the GitLab Review Workload Dashboard to find other available reviewers.

    To read more on how to use the reviewer roulette, please take a look at the Engineering workflow and code review guidelines. Please consider assigning a reviewer or maintainer who is a domain expert in the area of the merge request.

    Once you've decided who will review this merge request, assign them as a reviewer! Danger does not automatically notify them for you.

    If needed, you can retry the :repeat: danger-review job that generated this comment.

    Generated by :no_entry_sign: Danger

  • Jerry Seto added 1075 commits

    added 1075 commits

    Compare with previous version

  • Contributor

    Allure report

    allure-report-publisher generated test report!

    e2e-test-on-gdk: :exclamation: test report for 7cf18b21

    expand test summary
    +------------------------------------------------------------------+
    |                          suites summary                          |
    +-------------+--------+--------+---------+-------+-------+--------+
    |             | passed | failed | skipped | flaky | total | result |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Plan        | 47     | 0      | 0       | 41    | 47    | ❗     |
    | Create      | 27     | 0      | 1       | 20    | 28    | ❗     |
    | Manage      | 12     | 0      | 1       | 12    | 13    | ❗     |
    | Data Stores | 20     | 0      | 0       | 15    | 20    | ❗     |
    | Govern      | 19     | 0      | 0       | 18    | 19    | ❗     |
    | Verify      | 8      | 0      | 0       | 8     | 8     | ❗     |
    +-------------+--------+--------+---------+-------+-------+--------+
    | Total       | 133    | 0      | 2       | 114   | 135   | ❗     |
    +-------------+--------+--------+---------+-------+-------+--------+

    e2e-package-and-test: :exclamation: test report for 7cf18b21

    expand test summary
    +-------------------------------------------------------------+
    |                       suites summary                        |
    +--------+--------+--------+---------+-------+-------+--------+
    |        | passed | failed | skipped | flaky | total | result |
    +--------+--------+--------+---------+-------+-------+--------+
    | Create | 270    | 0      | 32      | 2     | 302   | ❗     |
    +--------+--------+--------+---------+-------+-------+--------+
    | Total  | 270    | 0      | 32      | 2     | 302   | ❗     |
    +--------+--------+--------+---------+-------+-------+--------+
  • Jerry Seto added 6 commits

    added 6 commits

    Compare with previous version

  • Jerry Seto added 584 commits

    added 584 commits

    Compare with previous version

  • Jerry Seto changed title from Draft: Add new strategy for file size check to Draft: Check changes for files over a limit

    changed title from Draft: Add new strategy for file size check to Draft: Check changes for files over a limit

  • Jerry Seto changed the description

    changed the description

  • Jerry Seto added 1 commit

    added 1 commit

    Compare with previous version

  • Jerry Seto changed the description

    changed the description

  • Jerry Seto mentioned in merge request !125245 (merged)

    mentioned in merge request !125245 (merged)

  • Jerry Seto marked this merge request as ready

    marked this merge request as ready

  • Jerry Seto changed the description

    changed the description

  • Jerry Seto resolved all threads

    resolved all threads

  • Jerry Seto added 1 commit

    added 1 commit

    Compare with previous version

  • Jerry Seto added 3 commits

    added 3 commits

    Compare with previous version

  • Jerry Seto requested review from @jpcyiza

    requested review from @jpcyiza

  • Patrick Cyiza
  • Patrick Cyiza approved this merge request

    approved this merge request

  • :wave: @jpcyiza, thanks for approving this merge request.

    This is the first time the merge request is approved. To ensure full test coverage, a new pipeline will be started shortly.

    For more info, please refer to the following links:

  • Patrick Cyiza requested review from @a_akgun

    requested review from @a_akgun

  • Alper Akgun
  • Alper Akgun
  • Jerry Seto added 1 commit

    added 1 commit

    • 0f4de86f - Log when checking for blob and refactor

    Compare with previous version

  • Alper Akgun approved this merge request

    approved this merge request

  • Alper Akgun resolved all threads

    resolved all threads

  • Patrick Cyiza removed review request for @jpcyiza

    removed review request for @jpcyiza

  • Jerry Seto deleted the 393535-new-strategy branch. This merge request now targets the master branch

    deleted the 393535-new-strategy branch. This merge request now targets the master branch

  • Jerry Seto added 864 commits

    added 864 commits

    Compare with previous version

  • Jerry Seto changed milestone to %16.3

    changed milestone to %16.3

  • Alper Akgun resolved all threads

    resolved all threads

  • Alper Akgun approved this merge request

    approved this merge request

  • Alper Akgun enabled an automatic merge when the pipeline for 533d4294 succeeds

    enabled an automatic merge when the pipeline for 533d4294 succeeds

  • merged

  • Alper Akgun mentioned in commit a2833ffa

    mentioned in commit a2833ffa

  • added workflowstaging label and removed workflowcanary label

  • mentioned in issue #467556 (closed)

  • Stan Hu mentioned in issue #469079

    mentioned in issue #469079

  • Please register or sign in to reply
    Loading